Skip to content

Fix commute-ppr pass to correctly handle PPR's operands across different blocks #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sengthai wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −1
Open

Fix commute-ppr pass to correctly handle PPR's operands across different blocks #2267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00d5ac6
Fix commute_ppr pass to correctly handle PPRs across different blocks…
sengthai Dec 4, 2025
668fe56
update changelog
sengthai Dec 4, 2025
d605ea9
Merge branch 'main' into fix-commute-ppr
sengthai Dec 4, 2025
6221195
remove unnessary header
sengthai Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/releases/changelog-dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@

This fix enables automatic qubit management to be used with gradients.


* Fixed the :func:`~.passes.commute_ppr` pass incorrectly modifying operands of PPRs that live in
different blocks.
[(#2267)](https://github.com/PennyLaneAI/catalyst/pull/2267)

* The `--inline-nested-module` pass no longer renames external function declarations.
[(#2244)](https://github.com/PennyLaneAI/catalyst/pull/2244)

Expand Down
6 changes: 5 additions & 1 deletion mlir/lib/QEC/Transforms/CommutePPR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@ void moveCliffordPastNonClifford(const PauliStringWrapper &lhsPauli,

// Update the use of value in newRHSOperands
for (unsigned i = 0; i < newRHSOperands.size(); i++) {
newRHSOperands[i].replaceAllUsesExcept(nonCliffordOp.getOutQubits()[i], nonCliffordOp);
newRHSOperands[i].replaceUsesWithIf(
nonCliffordOp.getOutQubits()[i], [&](OpOperand &operand) {
return operand.getOwner() != nonCliffordOp &&
operand.getOwner()->getBlock() == lhs->getBlock();
});
}

rewriter.replaceOp(rhs, rhs.getInQubits());
Expand Down