Skip to content

Conversation

@mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Dec 9, 2025

  • Add xdsl and xdsl-jax to the requirements in setup.py
  • Remove use of pytest.importorskip("xdsl") from the tests
  • Add XDSL_TESTS argument to the Makefile for make pytest. ON by default
  • Remove separate steps for xDSL tests in the GitHub workflows. Instead, xDSL tests are skipped by setting XDSL_TESTS=OFF or explicitly using the -m "not xdsl" pytest marker.
    • Question for reviewers: Should the check-pl-compat.yml workflow run tests that require graphviz to be installed?

[sc-105557]

@mudit2812 mudit2812 added dependencies Pull requests that update a dependency file unified compiler Pull requests for the integration with xDSL labels Dec 9, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To graphviz or not to graphviz?

@mudit2812 mudit2812 requested a review from dime10 December 10, 2025 21:23
@mudit2812 mudit2812 marked this pull request as ready for review December 10, 2025 21:28
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.33%. Comparing base (9f08f42) to head (f89de8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2282   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files         107      107           
  Lines       12962    12962           
  Branches     1076     1076           
=======================================
  Hits        12616    12616           
  Misses        283      283           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mudit2812 mudit2812 added the author:build-wheels Run the wheel building workflows on this Pull Request label Dec 11, 2025
@dime10 dime10 requested a review from a team December 11, 2025 18:40
@mudit2812 mudit2812 requested a review from joeycarter December 16, 2025 19:00
Copy link
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:build-wheels Run the wheel building workflows on this Pull Request dependencies Pull requests that update a dependency file do-not-merge unified compiler Pull requests for the integration with xDSL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants