-
Notifications
You must be signed in to change notification settings - Fork 708
Quantum Monte Carlo Graph Decomp #8602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum Monte Carlo Graph Decomp #8602
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8602 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 587 587
Lines 62064 62083 +19
==========================================
+ Hits 61708 61726 +18
- Misses 356 357 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gabrielasd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @comp-phys-marc!
JerryChen97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tried using graph decomp for the qmc decomposition issue in doctests that has been haunting recently? I wonder whether it will be resolved by graph decomp
Hi @JerryChen97 are you asking me to put |
No not in the docstring (it's public facing and should not be changed arbitrarily), just curious if we have tried it on that problematic case |
I am not sure how to address the doctest issue without changing the docstring. |
Context: We would like to port the
QuantumMonteCarlodecomposition to the new graph based system.Description of the Change: Adds a capture compatible graph based decomposition to the class.
Benefits: The template can be decomposed via the graph.
Possible Drawbacks: N/A
Related ShortCut Stories: [sc-103431]