Skip to content

Conversation

@comp-phys-marc
Copy link
Contributor

Context: We would like to port the QuantumMonteCarlo decomposition to the new graph based system.

Description of the Change: Adds a capture compatible graph based decomposition to the class.

Benefits: The template can be decomposed via the graph.

Possible Drawbacks: N/A

Related ShortCut Stories: [sc-103431]

@comp-phys-marc comp-phys-marc marked this pull request as ready for review November 6, 2025 20:29
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.42%. Comparing base (75261ce) to head (fef7986).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8602      +/-   ##
==========================================
- Coverage   99.42%   99.42%   -0.01%     
==========================================
  Files         587      587              
  Lines       62064    62083      +19     
==========================================
+ Hits        61708    61726      +18     
- Misses        356      357       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gabrielasd gabrielasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comp-phys-marc!

Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tried using graph decomp for the qmc decomposition issue in doctests that has been haunting recently? I wonder whether it will be resolved by graph decomp

@comp-phys-marc
Copy link
Contributor Author

Have we tried using graph decomp for the qmc decomposition issue in doctests that has been haunting recently? I wonder whether it will be resolved by graph decomp

Hi @JerryChen97 are you asking me to put qml.decomposition.enable_graph() in the docstring?

@JerryChen97
Copy link
Contributor

Have we tried using graph decomp for the qmc decomposition issue in doctests that has been haunting recently? I wonder whether it will be resolved by graph decomp

Hi @JerryChen97 are you asking me to put qml.decomposition.enable_graph() in the docstring?

No not in the docstring (it's public facing and should not be changed arbitrarily), just curious if we have tried it on that problematic case

@comp-phys-marc
Copy link
Contributor Author

Have we tried using graph decomp for the qmc decomposition issue in doctests that has been haunting recently? I wonder whether it will be resolved by graph decomp

Hi @JerryChen97 are you asking me to put qml.decomposition.enable_graph() in the docstring?

No not in the docstring (it's public facing and should not be changed arbitrarily), just curious if we have tried it on that problematic case

I am not sure how to address the doctest issue without changing the docstring.

@comp-phys-marc comp-phys-marc added this pull request to the merge queue Nov 14, 2025
Merged via the queue into master with commit 91313cf Nov 14, 2025
55 checks passed
@comp-phys-marc comp-phys-marc deleted the feature/quantum_monte_carlo_graph_decomp branch November 14, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants