-
Notifications
You must be signed in to change notification settings - Fork 706
[WIP] Bump jax 0.7.2 #8604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] Bump jax 0.7.2 #8604
Conversation
|
|
- Remove custom_partial_eval_rule from _capture_qnode.py which was causing finite-diff to fail with JAX 0.7.2 - Document all 4 patches in jax_patches.py as REQUIRED (verified via testing) - Remove unnecessary xfails in finite-diff and JVP tests - All capture tests pass (1583/1583)
- Comment out external-libraries-tests from all-tests-passed and upload-reports needs - The test job itself already has conditional skip logic - This allows CI to pass without waiting for external library tests
| - core-tests | ||
| - all-interfaces-tests | ||
| - external-libraries-tests | ||
| # - external-libraries-tests # Skipped for JAX 0.7.2 migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temp skip until 0.7.2 is fully compatible with catalyst
Co-authored-by: Hong-Sheng Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is also needed due to the new Literal in jax 0.7.2
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8604 +/- ##
==========================================
- Coverage 99.43% 96.40% -3.03%
==========================================
Files 587 588 +1
Lines 61879 62162 +283
==========================================
- Hits 61529 59927 -1602
- Misses 350 2235 +1885 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Context:
It seems that jax 0.7.2 has some "good" feature that we don't need const var anymore.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: