Skip to content

Conversation

@JerryChen97
Copy link
Contributor

Context:
It seems that jax 0.7.2 has some "good" feature that we don't need const var anymore.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@JerryChen97
Copy link
Contributor Author

slice issue is clear: when I was locally developing I used 3.12, where slice's are hashable, so it passed our hashabler test without being converted to tuples. But on CI 3.11 python has slices as not hashable. So there's fundamental conflict. Need to adjust the patcher

@JerryChen97 JerryChen97 added the WIP 🚧 Work-in-progress label Nov 12, 2025
@JerryChen97 JerryChen97 self-assigned this Nov 12, 2025
- Remove custom_partial_eval_rule from _capture_qnode.py which was causing
  finite-diff to fail with JAX 0.7.2
- Document all 4 patches in jax_patches.py as REQUIRED (verified via testing)
- Remove unnecessary xfails in finite-diff and JVP tests
- All capture tests pass (1583/1583)
- Comment out external-libraries-tests from all-tests-passed and upload-reports needs
- The test job itself already has conditional skip logic
- This allows CI to pass without waiting for external library tests
- core-tests
- all-interfaces-tests
- external-libraries-tests
# - external-libraries-tests # Skipped for JAX 0.7.2 migration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp skip until 0.7.2 is fully compatible with catalyst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is also needed due to the new Literal in jax 0.7.2

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 92.04893% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.40%. Comparing base (4c31904) to head (7a578e6).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nnylane/transforms/optimization/cancel_inverses.py 66.66% 9 Missing ⚠️
pennylane/capture/jax_patches.py 92.92% 8 Missing ⚠️
pennylane/ops/functions/equal.py 81.81% 4 Missing ⚠️
pennylane/ops/qubit/observables.py 88.88% 2 Missing ⚠️
...templates/subroutines/qchem/all_singles_doubles.py 60.00% 2 Missing ⚠️
pennylane/capture/custom_primitives.py 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8604      +/-   ##
==========================================
- Coverage   99.43%   96.40%   -3.03%     
==========================================
  Files         587      588       +1     
  Lines       61879    62162     +283     
==========================================
- Hits        61529    59927    -1602     
- Misses        350     2235    +1885     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP 🚧 Work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants