-
Notifications
You must be signed in to change notification settings - Fork 706
Control flow fallback #8615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Control flow fallback #8615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello. You may have forgotten to update the changelog!
|
albi3ro
commented
Nov 10, 2025
albi3ro
commented
Nov 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8615 +/- ##
==========================================
- Coverage 99.43% 99.43% -0.01%
==========================================
Files 587 587
Lines 61885 61896 +11
==========================================
+ Hits 61536 61546 +10
- Misses 349 350 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dime10
reviewed
Nov 11, 2025
dime10
approved these changes
Nov 11, 2025
comp-phys-marc
approved these changes
Nov 11, 2025
albi3ro
commented
Nov 11, 2025
Co-authored-by: Isaac De Vlugt <[email protected]>
isaacdevlugt
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
One of the challenges with turning autograph on by default is that it converts things it shouldn't convert into a structured for loop. When that happens, the whole program just fails and falls over.
To make things more user friendly, we instead just fall back to a standard python for loop. Less performant, but at least it works.
Description of the Change:
Fall back to standard python for loop if the capture of the jaxpr fails.
Benefits:
Things continue to run.
This fallback can be turned off by turning the
qml.exceptions.CaptureWarninginto an error.Possible Drawbacks:
Things are unrolled, even if unrolled with a warning.
Related GitHub Issues:
[sc-103710]