-
Notifications
You must be signed in to change notification settings - Fork 715
Ring arithmetic bug fix for RS decomposition #8636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8636 +/- ##
========================================
Coverage 99.43% 99.43%
========================================
Files 588 588
Lines 62706 62812 +106
========================================
+ Hits 62352 62458 +106
Misses 354 354 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AntonNI8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender ! happy to approve once you add the tests for ZOmega
josephleekl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @obliviateandsurrender !
JerryChen97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience! Feel free to re-tag me in the following-up PR's
AntonNI8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @obliviateandsurrender! 🚀
Context: This fixes GCD and modulo computations for the
ZSqrtTwoandZOmegaring elements.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: