Optax QSP Iterative Solver #8685
Open
+127
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
external
Contributor
Author
JerryChen97
requested changes
Nov 26, 2025
Contributor
JerryChen97
left a comment
JerryChen97
left a comment
There was a problem hiding this comment.
Thanks a lot for the work! Some workflow changes are needed, and then let's merge master into this branch and I'll approve the CI to run more auto checks
Contributor
There was a problem hiding this comment.
This change should be reverted
Contributor
There was a problem hiding this comment.
These seem to be coming from a certain merge conflit in the past. Should be all removed safely
Contributor
There was a problem hiding this comment.
We can revert this change and then when all the other conflicts are resolved merge master into this branch then files like _version should be automatically updated
cvqmm
force-pushed
the
optax_qsp_iter_solver
branch
from
849fd1c to
967b8b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Use Optax optimizers instead of Scipy's
Description of the Change:
Benefits: JAX friendly & whole optimization loop can be jit-compiled
Possible Drawbacks:
Related GitHub Issues: