Skip to content

Conversation

@JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Nov 25, 2025

Context:
Subset of #8525 focusing on hashability, as well as the jax API updates

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-102157]

@JerryChen97 JerryChen97 requested a review from albi3ro November 26, 2025 19:20
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. To me, it makes sense to ensure that the xfailed templates are fixed before the release. @albi3ro let me know if you think that we can defer it to after the release.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JerryChen97 JerryChen97 added the urgent Mark a pull request as high priority label Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.42%. Comparing base (1b19b46) to head (3dc74a5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8701      +/-   ##
==========================================
- Coverage   99.43%   99.42%   -0.01%     
==========================================
  Files         587      587              
  Lines       62475    62419      -56     
==========================================
- Hits        62119    62063      -56     
  Misses        356      356              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blacksmith-sh

This comment has been minimized.

@JerryChen97 JerryChen97 added this pull request to the merge queue Nov 29, 2025
Merged via the queue into master with commit e5c81be Nov 29, 2025
54 of 55 checks passed
@JerryChen97 JerryChen97 deleted the bump-jax-api-hashability branch November 29, 2025 06:36
@JerryChen97 JerryChen97 restored the bump-jax-api-hashability branch November 29, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

urgent Mark a pull request as high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants