Standardize the output format of qml.specs
#8713
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello. You may have forgotten to update the changelog!
|
jzaia18
commented
Nov 28, 2025
| tape_resources.gate_sizes, | ||
| tape_resources.depth, | ||
| Shots(shots_from_dev), | ||
| resources = SpecsResources( # temporary until shots get updated on tape ! |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| resources = SpecsResources( # temporary until shots get updated on tape ! | |
| resources = SpecsResources( |
Should I remove this comment? It seems to have been left here for a very long time
jzaia18
commented
Nov 28, 2025
| """A special dictionary for storing the specs of a circuit. Used to customize ``KeyError`` messages.""" | ||
|
|
||
| def __getitem__(self, __k): | ||
| if __k == "num_diagonalizing_gates": |
Contributor
Author
There was a problem hiding this comment.
I removed the warning associated with this since this specific field since it was removed back in March (several releases ago).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.specsmakes very few guarantees on the shape of its output. This PR aims to make a single unified out type forqml.specs, which contains all of (and only) the information needed for circuit inspection.Description of the Change:
SpecsResourcesandSpecsResultclassesspecsfunctions throughout PennyLane to make use of the new classesBenefits:
Cleaner and more consistent
specsreturns.Possible Drawbacks:
Introduces another "resources" object into PennyLane. A followup PR should restructure these PRs such that all of them inherit from a common base class.
Related GitHub Issues:
[sc-104965]