Radiation Insulation Refactor Reopen#607
Conversation
Makes some adjustment to the way radiation waves spread through insulation. Previously as a radiation wave expanded, insulation (like walls, for example), did very little to stem the overall strength of the wave. With the change: Insulation blockers have a greater impact on the overall insulation effect, reducing the radiation wave intensity. Greater insulation values also have more impact than before. Only the best insulation is taken per tile, so it is not possible to stack insulation values. This change is done for sanity and to reduce computation. Insulating blockers were expanded and adjusted. Blast doors now have great insulation, for example. Additionally, if you open a door, it will have an impact on the overall radiation wave as the door no longer will act as insulation. Previously, doors and other obstacles that could open and closed always counted as an insulation blocker.
…FslashN/Pentest-Test into Radiation-Insulation-Adjustment
Modularizes stuff, thanks to @Ossa88 for a lot of the original modularization work.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…Pentest-Test into NEW-RAD-REFACTOR-AAAAAA
Looks like some lines were removed.
I forgot to actually remove the changes to some individual files.
Reverting a few more lines I missed.
Forgot to remove two lines. Oops.
|
Love how there was a merge conflict that wasnt a real merge conflict and github only told me well after i merged small things |
|
It's failing for some strange reason. Not really sure. |
Thats the DMI 5 checker from paradise... it might be down atm Just allow the other tests as those are generally more important. |
|
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
705cbd6
2 participants
About The Pull Request
Branched copy of: (#606)
Why It's Good For The Game
As the previous commit but all the modularization issues are now ironed out.
Changelog
🆑
refactor: Refactored radiation spread code as well as insulation.