Skip to content

Should fix niche MC crashing infinite loop#649

Open
Ossa88 wants to merge 1 commit into
PentestSS13:masterfrom
Ossa88:infinite-loop
Open

Should fix niche MC crashing infinite loop#649
Ossa88 wants to merge 1 commit into
PentestSS13:masterfrom
Ossa88:infinite-loop

Conversation

@Ossa88
Copy link
Copy Markdown
Collaborator

@Ossa88 Ossa88 commented Mar 31, 2026

About The Pull Request

Though the weirdest of circumstances, a baby gruboid can die (and thus explode) throwing another mob. If said mob flies though a gravity anomaly, the game attempts to paralyze and throw said mob. Simple mobs cant be paralyzed and are thus not thrown.

But because the explosion had the mob being thrown, it keeps attempting to throw a thrown mob. And since it cant it keeps attempting to throw a thrown mob. And since it cant it keeps attempting to throw a thrown mob.

This caused an infinite loop that caused the MC to crash 5 times in a row before finally finishing processing whatever the fuck happened.

Why It's Good For The Game

Should prevent whatever the fuck happened...

Changelog

🆑
fix: Grav Anomalies should no longer attempt to kill the universe
/:cl:

@Ossa88 Ossa88 requested a review from Constellado as a code owner March 31, 2026 08:33
@Ossa88 Ossa88 marked this pull request as draft March 31, 2026 08:33
@Constellado
Copy link
Copy Markdown
Collaborator

I see this is draft, is it TMable?

@Ossa88
Copy link
Copy Markdown
Collaborator Author

Ossa88 commented Apr 9, 2026

I see this is draft, is it TMable?

Yah it can be TMed.

The reason it is a draft is that I was still ensuring that this would fix the issue. The problem is the conditions to make the issue happen are so rare, that I have not been able to forcefully replicate the issue

@Ossa88 Ossa88 marked this pull request as ready for review April 10, 2026 04:31
@Ossa88 Ossa88 added the TM Candidate This PR is approved for TM label Apr 10, 2026
@Ossa88 Ossa88 changed the title [DRAFT] Should fix niche MC crashing infinite loop Should fix niche MC crashing infinite loop Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions Bot added the Stale label May 19, 2026
@Ossa88 Ossa88 removed the Stale label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Code Change TM Candidate This PR is approved for TM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants