Skip to content

[Framework] Rework Extras draw #1422

Closed
chaserli wants to merge 2 commits into
Phobos-developers:developfrom
chaserli:extradisplay
Closed

[Framework] Rework Extras draw #1422
chaserli wants to merge 2 commits into
Phobos-developers:developfrom
chaserli:extradisplay

Conversation

@chaserli
Copy link
Copy Markdown
Contributor

Everyone (e.g. #1287 #1309 #1395 #1418 #1148) is doing their own work separately and creating overhead and incompatibilities.
As we've stated before the entire Healthbar drawing system needs to be overwritten completely.

This settles the framework for all these.

TODO:

  • BarType + DigitalsType
  • For : HP, SP, IC timer, Temporal, ROF timer, Reload timer, Factory progress, SW progress, ...
  • Condition: selected/always
  • Location: Attached/ Global

@chaserli chaserli added the Minor Minor feature and/or fix, not a lot of changes or they are not significant label Nov 11, 2024
@chaserli chaserli marked this pull request as draft November 11, 2024 12:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 11, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@chaserli chaserli closed this Feb 24, 2025
@Metadorius
Copy link
Copy Markdown
Member

Why?

@chaserli
Copy link
Copy Markdown
Contributor Author

Why?

To reduce PR number.

I'm currently unavailable to work on this subject, more specifically properly dehardcoding stuff and design ini structure, which might require constant feedback and discussion. Meanwhile people might be impatient for things like #1287 #1309 etc.

The common issue here and in the current digital display is the overhead, like the same draw point being calculated multiple times. Similar overhead also exists in vanilla code, if you don't use gdi ddraw you might not notice.

Will resume later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor feature and/or fix, not a lot of changes or they are not significant

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants