[Minor] Fix ForceWeapon.InRange not taking effect when attacking non-techno#1693
Merged
Coronia merged 5 commits intoJun 4, 2025
Merged
Conversation
Contributor
CrimRecya
commented
Jun 2, 2025
CrimRecya
commented
- Also encapsulated the function for Forcing specific weapon by target type #1631 to use.
github-actions
Bot
added
the
Minor
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
reviewed
Jun 2, 2025
Contributor
There was a problem hiding this comment.
It’d better to add a tag to customize whether ForceWeapon.InRange should affect empty ground, cuz 1) other ForceWeapon doesn’t really work on empty ground, so this is an exception, and 2) there’re cases when modders only want to use it on units only
Coronia
approved these changes
Jun 4, 2025
Contributor
Coronia
left a comment
Coronia
left a comment
There was a problem hiding this comment.
add doc for ForceWeapon.InRange.TechnoOnly and we're good
Coronia
force-pushed
the
develop-FcWpInRangeFix
branch
from
18d4476 to
15079f0
Compare
DeathFishAtEase
added a commit
to DeathFishAtEase/Phobos
that referenced
this pull request
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.