fix: use region.values for Scotland comparisons in loss function #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use region.values == "SCOTLAND" instead of region == "SCOTLAND" for consistent behavior with StringArray types. This matches the pattern used in test files and avoids potential issues with pandas StringArray comparisons. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove version pinning from black in CI workflow - Add changelog entry for region.values fix Co-Authored-By: Claude Opus 4.5 <[email protected]>
Match the pattern used in test_scotland_babies.py for consistency: - Keep region as Series (no .values on calculate) - Use region.values in comparison Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
region.values == "SCOTLAND"instead ofregion == "SCOTLAND"for consistent behavior with pandas StringArray typesChanges
scotland_children_under_16: useregion.valuesscotland_babies_under_1: useregion.values🤖 Generated with Claude Code