Skip to content
This repository was archived by the owner on Mar 7, 2024. It is now read-only.

fix: dont log huge lines when debug on#30

Merged
macobo merged 1 commit into
mainfrom
remove-some-problematic-logging
Oct 18, 2022
Merged

fix: dont log huge lines when debug on#30
macobo merged 1 commit into
mainfrom
remove-some-problematic-logging

Conversation

@macobo
Copy link
Copy Markdown
Contributor

@macobo macobo commented Oct 17, 2022

The removed code is responsible for some huge console.logs, which causes performance and reliability issues.

Related:

@github-actions
Copy link
Copy Markdown

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/opt/hostedtoolcache/node/16.17.1/x64/bin/npx' failed with exit code 1
St.
Category Percentage Covered / Total
🔴 Statements
52.73% (+0.94% 🔼)
116/220
🔴 Branches
41.05% (+0.85% 🔼)
39/95
🟡 Functions 60.98% 25/41
🔴 Lines
51.87% (+0.95% 🔼)
111/214

Test suite run failed

Failed tests: 2/2. Failed suites: 1/1.
  ● handles events

    TypeError: meta.jobs.copyIntoSnowflakeJob is not a function

      598 |     async runEveryMinute(meta) {
      599 |         // Run copyIntoSnowflake more often to spread out load better
    > 600 |         await meta.jobs.copyIntoSnowflakeJob({}).runIn(20, 'seconds')
          |                         ^
      601 |         await meta.jobs.copyIntoSnowflakeJob({}).runIn(40, 'seconds')
      602 |         await copyIntoSnowflake(meta)
      603 |     },

      at Object.runEveryMinute (index.ts:600:25)
      at Object.<anonymous> (index.test.ts:100:41)

  ● handles > 1k files

    TypeError: meta.jobs.copyIntoSnowflakeJob is not a function

      598 |     async runEveryMinute(meta) {
      599 |         // Run copyIntoSnowflake more often to spread out load better
    > 600 |         await meta.jobs.copyIntoSnowflakeJob({}).runIn(20, 'seconds')
          |                         ^
      601 |         await meta.jobs.copyIntoSnowflakeJob({}).runIn(40, 'seconds')
      602 |         await copyIntoSnowflake(meta)
      603 |     },

      at Object.runEveryMinute (index.ts:600:25)
      at Object.<anonymous> (index.test.ts:162:27)

Report generated by 🧪jest coverage report action from f33caa8

@macobo macobo merged commit f0f2c1e into main Oct 18, 2022
@macobo macobo deleted the remove-some-problematic-logging branch October 18, 2022 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants