-
Notifications
You must be signed in to change notification settings - Fork 37
docs: add docs for using ascend device in volcano #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: james <[email protected]>
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
windsonsea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
Signed-off-by: james <[email protected]>
windsonsea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one more concern:
You need to select a position to add the nav:
https://github.com/Project-HAMi/website/blob/master/sidebars.js#L30
Signed-off-by: james <[email protected]>
windsonsea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DSFans2014, windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No more comments come in. It's time to merge this. /lgtm |
The docs added are copied from Project-HAMi/HAMi#1488