Skip to content

perf: speed up Selection.Text by outlining recursion #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mna merged 1 commit into from
May 28, 2026
+13 −15
Merged

perf: speed up Selection.Text by outlining recursion #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions property.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,27 +59,25 @@ func (s *Selection) SetAttr(attrName, val string) *Selection {
// elements, including their descendants.
func (s *Selection) Text() string {
var builder strings.Builder

// Slightly optimized vs calling Each: no single selection object created
var f func(*html.Node)
f = func(n *html.Node) {
if n.Type == html.TextNode {
// Keep newlines and spaces, like jQuery
builder.WriteString(n.Data)
}
if n.FirstChild != nil {
for c := n.FirstChild; c != nil; c = c.NextSibling {
f(c)
}
}
}
for _, n := range s.Nodes {
f(n)
s.textHelper(n, &builder)
}

return builder.String()
}

func (s *Selection) textHelper(n *html.Node, builder *strings.Builder) {
if n.Type == html.TextNode {
// Keep newlines and spaces, like jQuery
builder.WriteString(n.Data)
}
if n.FirstChild != nil {
for c := n.FirstChild; c != nil; c = c.NextSibling {
s.textHelper(c, builder)
}
}
}

// Size is an alias for Length.
func (s *Selection) Size() int {
return s.Length()
Expand Down
Loading