Skip to content

perf: presize node-set maps in mapNodes, ClosestNodes and winnowNodes #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mna merged 2 commits into from
May 28, 2026
+3 −3
Merged

perf: presize node-set maps in mapNodes, ClosestNodes and winnowNodes #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f07eeb
perf: presize node-set maps in mapNodes, ClosestNodes and winnowNodes
jvoisin May 27, 2026
bd4f514
Merge branch 'master' into precise
mna May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func winnowNodes(sel *Selection, nodes []*html.Node, keep bool) []*html.Node {
return result
}

set := make(map[*html.Node]bool)
set := make(map[*html.Node]bool, len(nodes))
for _, n := range nodes {
set[n] = true
}
Expand Down
4 changes: 2 additions & 2 deletions traversal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func (s *Selection) ClosestMatcher(m Matcher) *Selection {
// ClosestNodes gets the first element that matches one of the nodes by testing the
// element itself and traversing up through its ancestors in the DOM tree.
func (s *Selection) ClosestNodes(nodes ...*html.Node) *Selection {
set := make(map[*html.Node]bool)
set := make(map[*html.Node]bool, len(nodes))
for _, n := range nodes {
set[n] = true
}
Expand Down Expand Up @@ -696,7 +696,7 @@ func mapNodes(nodes []*html.Node, f func(int, *html.Node) []*html.Node) (result
return f(0, nodes[0])
}

set := make(map[*html.Node]bool)
set := make(map[*html.Node]bool, len(nodes))
for i, n := range nodes {
if vals := f(i, n); len(vals) > 0 {
result = appendWithoutDuplicates(result, vals, set)
Expand Down
Loading