perf: collapse per-child loop in findWithMatcher#566
Open
jvoisin wants to merge 1 commit into
Open
Conversation
findWithMatcher iterated over each element child of every input node
and called m.MatchAll(c) on each, then append-spread-merged the
returned slices into one result. For a node with K element children
this was K independent cascadia tree walks, each starting with a
fresh nil result slice.
This commit calls m.MatchAll(n) once on the input node itself. cascadia walks n
plus all descendants in document order, so if n matches it is always the first
element of the returned slice, strip it to preserve jQuery Find's "descendants
only" semantics.
Benchmarks (-count=20, benchtime=500ms, linux/arm64):
sec/op B/op allocs/op
Find ~ (-10%) -23.53% -7.69%
FindWithinSelection ~ -11.06% -43.53%
FindNodes -12.36% ~ ~
Has ~ -17.20% -7.14%
Add ~ -5.13% -9.09%
Closest -37.34% ~ ~
ClosestSelection -43.77% ~ ~
ClosestNodes -36.56% ~ ~
MetalReviewExample ~ -5.42% -11.19%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findWithMatcher iterated over each element child of every input node and called m.MatchAll(c) on each, then append-spread-merged the returned slices into one result. For a node with K element children this was K independent cascadia tree walks, each starting with a fresh nil result slice.
This commit calls m.MatchAll(n) once on the input node itself. cascadia walks n plus all descendants in document order, so if n matches it is always the first element of the returned slice, strip it to preserve jQuery Find's "descendants only" semantics.
Benchmarks (-count=20, benchtime=500ms, linux/arm64):