Conversation
Member
Author
|
Hey @afshin, do you mind taking a look over the PR? Thanks! |
afshin
reviewed
Jun 2, 2025
afshin
reviewed
Jun 2, 2025
afshin
approved these changes
Jun 2, 2025
Member
afshin
left a comment
There was a problem hiding this comment.
Thank you! This looks good.
I think longer term we should have a discussion about the interaction between settings and secrets and how to minimize the risks involved in storing secrets, but that's outside the scope of this PR.
Member
Author
|
Thank you for the review! And I agree about a follow-up discussion on the secrets stored from the settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up the settings credentials provider for the extension and connect the secret inputs to the
SecretsManagerfromjupyter-secrets-manager.The credentials can be set by accessing
Settings->Settings Editor->Credentials Providerand include the bucketname,regionandendpoint, as well as an optional path to a directory within the bucket to act asroot. TheaccessKeyIDandsecretAccessKeyare considered secret fields and their inputs are connected to theSecretsManagerfromjupyter-secrets-manager.Any changes made to the credentials are automatically saved and the drive file browser is updated, the update can take a few seconds to be visible. Every time a field is changed, a new
Driveis instated with the new credentials. As the secret fields are not saved, when instating theDrivewe fetch the secret values using the provided secrettoken.The
authFileBrowserplugin was updated to connect to the credentials provider settings. Currently, it first tries to fetch the settings and if they exist thefactoryreturns them, otherwise it looks for theprocess.envenvironment variables, which can be used with the development version.