Add support for async model creation#22
Merged
davidbrochart merged 2 commits intomainfrom Feb 7, 2025
Merged
Conversation
4 tasks
Member
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
Maybe there could be a new method in JupyterYModel, something like async initialize(commMetadata), that would do nothing by default and that could be overridden in subclasses, that would be executed first. With that, I don't think we would need to change the existing API?
Member
Author
|
Thanks for the comment, indeed, I'll try that |
davidbrochart
approved these changes
Feb 7, 2025
Member
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
Thanks @martinRenou.
Strictly speaking I think this is still a breaking change, since the ydoc is now created asynchronously, so it will fail if you try to access it before waiting for ready, right?
Member
Author
|
Ah indeed, let's make a 0.4.0 just to be sure? |
Member
|
Yes, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a breaking change on the typing (makes TypeScript fail) but it should be fine at runtime 🤷🏽♂️