Remove unnecessary and costly calls to typing.get_type_hints#274
Merged
Remove unnecessary and costly calls to typing.get_type_hints#274
Conversation
cbourjau
commented
Feb 17, 2026
Comment on lines
-99
to
-100
| # Cast to tuple to avoid accidental mutation | ||
| setattr(self, field.name, tuple(value)) |
Collaborator
Author
There was a problem hiding this comment.
This removal prompted me to update the type hints in this PR.
|
On a ~3600 node model, this change reduces build time from 2:50 to 2:16 (~20%)! 🚀 |
SamuelLessmannQC
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling the construction of fairly large graphs by @SamuelLessmannQC found that we spend a considerable fraction of the run time in
typing.get_type_hints. This PR refactors the code in a minimally invasive way to remove unnecessary calls to that function.On a larger picture, I'd like to refactor this code for a very long time, but that is on an equally low priority. As it stands right now, each
Nodehas an associatedInputsandOutputstype. The machinery around those is fairly complex, but ultimately performs only some simple validations. Alas, things work splendidly, so I don't think this is the day to make a larger refactor.Checklist
CHANGELOG.rstentry