refactor: RFC: remove helpers (post-RPITIT TLC)#181
Draft
Conversation
acl-cqc
commented
Jan 21, 2025
| fn all_neighbours(&self, node: NodeIndex) -> impl Iterator<Item = NodeIndex> + Clone; | ||
| } | ||
| fn get_connections( | ||
| &self, |
Contributor
Author
There was a problem hiding this comment.
The line count would look significantly better if the old, delegate!, versions of these didn't exceed the line length limit !!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## acl/port_links #181 +/- ##
==================================================
- Coverage 83.54% 83.49% -0.06%
==================================================
Files 24 24
Lines 6315 6320 +5
Branches 6315 6320 +5
==================================================
+ Hits 5276 5277 +1
- Misses 967 969 +2
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. |
c3fa811 to
30f998e
Compare
CodSpeed Performance ReportMerging #181 will not alter performanceComparing Summary
|
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't really need the various helpers typed as returning
NodeConnectionsetc. now, but removing them is a bit of a PITA because some of these structs contain each other (hence, must be parametrized) - so I haven't done all of them, thought I'd RFC first...Note: rebased to come after #188