Fix triggering of single/double tap action when performing system navigation gesture#1223
Open
equeim wants to merge 1 commit intoQuantumBadger:masterfrom
Open
Fix triggering of single/double tap action when performing system navigation gesture#1223equeim wants to merge 1 commit intoQuantumBadger:masterfrom
equeim wants to merge 1 commit intoQuantumBadger:masterfrom
Conversation
…igation gesture In that case we receive ACTION_CANCEL event and don't want to trigger tap actions.
5a26d12 to
145ab7f
Compare
Contributor
Author
|
Also discovered another issue when swipe overlay (when viewing image from a gallery) can get stuck when doing a very short swipe. The reason is that mCurrentTouchState may not be changed to ONE_FINGER_DRAG due to condition here: Not sure how to fix this properly without making this code even messier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen recording of issue that this patch fixes:
Screen_Recording_20240822_222226_RedReader.mp4