Add preference to enable/disable video looping#1323
Open
cliambrown wants to merge 3 commits intoQuantumBadger:masterfrom
Open
Add preference to enable/disable video looping#1323cliambrown wants to merge 3 commits intoQuantumBadger:masterfrom
cliambrown wants to merge 3 commits intoQuantumBadger:masterfrom
Conversation
Author
|
Not sure the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in issue #1075
(However, this PR does not distinguish between videos & gifs)
Note: Very sorry but I was not able to test this because I do not have a Reddit API key.
pref_behaviour_video_looppreference (default = true to match current behaviour) with a corresponding checkbox on the "Images/Video" settings pagepref_behaviour_video_loopis true, thePlayer.REPEAT_MODE_ONEconstant is used inExoPlayerWrapperView.javaas added in PR Make videos loop more smoothly #925Player.REPEAT_MODE_OFF("Normal playback without repetition", docs) is used instead