This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Open
Conversation
DongLiang-0
requested review from
cezpiw,
jakozaur,
mieciu,
nablaone and
pdelewski
pdelewski
reviewed
Jul 3, 2025
| typeName := col.Type.String() | ||
| // hasPrefix, not equal, because we can have DateTime64(3) and we want to catch it | ||
| if strings.HasPrefix(typeName, "DateTime64") { | ||
| if strings.HasPrefix(typeName, "datetime") { |
Contributor
There was a problem hiding this comment.
Suggested change
| if strings.HasPrefix(typeName, "datetime") { | |
| if strings.HasPrefix(typeName, "Datetime64") || strings.HasPrefix(typeName, "datetime") { |
pdelewski
reviewed
Jul 3, 2025
| return DateTime64 | ||
| } | ||
| if strings.HasPrefix(typeName, "DateTime") { | ||
| if strings.HasPrefix(typeName, "date") { |
Contributor
There was a problem hiding this comment.
Suggested change
| if strings.HasPrefix(typeName, "date") { | |
| if strings.HasPrefix(typeName, "DateTime") || strings.HasPrefix(typeName, "date") { |
pdelewski
reviewed
Jul 3, 2025
| func ResolveType(clickHouseTypeName string) reflect.Type { | ||
| switch clickHouseTypeName { | ||
| case "String", "LowCardinality(String)", "UUID", "FixedString": | ||
| func ResolveType(dorisTypeName string) reflect.Type { |
Contributor
There was a problem hiding this comment.
I think we have to have type resolver per each backend. It would make sense to introduce
type TypeResolver interface {
ResolveType(typeName string) reflect.Type
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.