Restore Shift detailed examine text#1506
Closed
strongkeep-debug wants to merge 2 commits into
Closed
Conversation
Author
|
Quick CI note after checking the red The reported Unity compile error is the base Local validation still passes: |
Collaborator
|
PRs by AI agents are not allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the current string-data path for detailed examine: hovering an examinable still shows its localized name by default, and holding Shift now appends the localized
DescriptionKeybelow it.The changed surface is intentionally limited to the existing
ExamineUI, because the project already hasNameKey/DescriptionKeyonExamineDataassets and the UI was only rendering the name.DescriptionKeyfield and localized string table fallbackbase.OnDisabled()before unsubscribingValidation:
I could not run Unity edit/play-mode tests in this environment because the required Unity 2021.3.15f1 editor is not installed locally.
Addresses #1394.