Skip to content

Restore Shift detailed examine text#1506

Closed
strongkeep-debug wants to merge 2 commits into
RE-SS3D:developfrom
strongkeep-debug:codex/1394-detailed-examine
Closed

Restore Shift detailed examine text#1506
strongkeep-debug wants to merge 2 commits into
RE-SS3D:developfrom
strongkeep-debug:codex/1394-detailed-examine

Conversation

@strongkeep-debug
Copy link
Copy Markdown

This restores the current string-data path for detailed examine: hovering an examinable still shows its localized name by default, and holding Shift now appends the localized DescriptionKey below it.

The changed surface is intentionally limited to the existing ExamineUI, because the project already has NameKey/DescriptionKey on ExamineData assets and the UI was only rendering the name.

Area Change Evidence
Hover examine Cache the current examinable so the UI can refresh while the cursor stays on the same object Shift state toggles call the same hover text update path
Detailed examine Holding left or right Shift appends the description below the name Uses the existing DescriptionKey field and localized string table fallback
Cleanup Disabled hook now calls base.OnDisabled() before unsubscribing Avoids the previous disable-path typo

Validation:

git diff --check
# passed

I could not run Unity edit/play-mode tests in this environment because the required Unity 2021.3.15f1 editor is not installed locally.

Addresses #1394.

@strongkeep-debug
Copy link
Copy Markdown
Author

Quick CI note after checking the red Run Tests job: this is a pull_request_target run, and the checkout step fetched and checked out base develop at 423f1d731f53b35d09d9e1a0b2b0a9e6477ebaa3, not this PR head 0d0d0ea803ef6f6b3c1df7528baf46e1ca04ba91.

The reported Unity compile error is the base LockLockerInteraction.cs missing using System for NotImplementedException; this PR head includes that import in the second commit. So the current red check is not exercising the pushed head changes.

Local validation still passes:

git diff --check

@Alainx277
Copy link
Copy Markdown
Collaborator

PRs by AI agents are not allowed

@Alainx277 Alainx277 closed this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants