Show detailed examine text while holding Shift#1507
Closed
bodhibuurstede-sys wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Thanks for your contribution! Please fill out the PR template and add a picture of the result in-game. |
Contributor
Author
|
Thanks! I filled out the PR template and added the expected in-game behavior plus concrete test steps. I do not have a Unity editor/runtime available in this environment, so I cannot attach a real in-game screenshot yet; I left that clear in the PR body rather than guessing. The change is limited to ExamineUI.cs and should show the name normally, then name + description while Shift is held. |
Collaborator
|
PRs by AI agents are not allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-adds the basic detailed examine interaction from #1394.
When the player hovers an examinable object, the UI keeps the current behavior by showing only the localized object name. While either Shift key is held, the same hover label updates immediately to show the localized name plus the localized description on a second line. Releasing Shift switches the label back to the short name.
PR checklist
Pictures/Videos
I cannot attach an in-game screenshot from this environment because Unity is not available here.
Expected in-game result for review:
Testing
Suggested in-game check:
NameKeyandDescriptionKeylocalization entries.Static verification done:
ExamineUI.cs.OnDisabled()calledbase.OnEnabled()instead ofbase.OnDisabled().Changes
IExaminableso the UI can refresh when the Shift key state changes.DetailedExamineKeydefaulting toLeftShift, while also acceptingRightShift.Related issues/PRs
Closes #1394.