Skip to content

Show detailed examine text while holding Shift#1507

Closed
bodhibuurstede-sys wants to merge 2 commits into
RE-SS3D:developfrom
bodhibuurstede-sys:codex/detailed-examine-shift
Closed

Show detailed examine text while holding Shift#1507
bodhibuurstede-sys wants to merge 2 commits into
RE-SS3D:developfrom
bodhibuurstede-sys:codex/detailed-examine-shift

Conversation

@bodhibuurstede-sys
Copy link
Copy Markdown
Contributor

@bodhibuurstede-sys bodhibuurstede-sys commented May 21, 2026

Summary

This PR re-adds the basic detailed examine interaction from #1394.

When the player hovers an examinable object, the UI keeps the current behavior by showing only the localized object name. While either Shift key is held, the same hover label updates immediately to show the localized name plus the localized description on a second line. Releasing Shift switches the label back to the short name.

PR checklist

  • The game builds properly without errors. Not verified locally; I do not have a Unity editor/runtime available in this Codex environment.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented where useful.
  • GitBook update is not needed for this small UI behavior restoration; the existing design page for detailed examine is still the relevant reference.

Pictures/Videos

I cannot attach an in-game screenshot from this environment because Unity is not available here.

Expected in-game result for review:

  • Hover an examinable object without Shift: the hover text shows only the localized object name.
  • Hold Left Shift or Right Shift while still hovering: the hover text updates to the object name on the first line and the detailed description on the second line.
  • Release Shift: the hover text returns to the name-only display.

Testing

Suggested in-game check:

  1. Open a scene with an object that has examine data with both NameKey and DescriptionKey localization entries.
  2. Hover the object without holding Shift.
  3. Confirm the label shows only the localized name.
  4. Hold Left Shift or Right Shift while still hovering the object.
  5. Confirm the label immediately expands to name plus description.
  6. Release Shift and confirm it returns to the name-only label.
  7. Move away from the object and confirm the label clears as before.

Static verification done:

  • Reviewed the diff and kept it limited to ExamineUI.cs.
  • Preserved the existing missing-localization fallback text.
  • Fixed the existing lifecycle typo where OnDisabled() called base.OnEnabled() instead of base.OnDisabled().

Changes

  • Stores the currently hovered IExaminable so the UI can refresh when the Shift key state changes.
  • Adds a serialized DetailedExamineKey defaulting to LeftShift, while also accepting RightShift.
  • Extracts hover text construction and localization lookup into small helpers.
  • Displays name-only text by default and name plus description while detailed examine is held.

Related issues/PRs

Closes #1394.

@Alainx277
Copy link
Copy Markdown
Collaborator

Thanks for your contribution! Please fill out the PR template and add a picture of the result in-game.

@bodhibuurstede-sys
Copy link
Copy Markdown
Contributor Author

Thanks! I filled out the PR template and added the expected in-game behavior plus concrete test steps. I do not have a Unity editor/runtime available in this environment, so I cannot attach a real in-game screenshot yet; I left that clear in the PR body rather than guessing. The change is limited to ExamineUI.cs and should show the name normally, then name + description while Shift is held.

@Alainx277
Copy link
Copy Markdown
Collaborator

PRs by AI agents are not allowed

@Alainx277 Alainx277 closed this May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detailed Examine

2 participants