cpu/nrf5x_common: copy vendor files only when newer #21868
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
the
Type: bug
github-actions
bot
added
Platform: ARM
crasbe
added
the
CI: ready for build
maribu
reviewed
Nov 11, 2025
maribu
approved these changes
Nov 11, 2025
leandrolanzieri
force-pushed
the
pr/nrf5x_common/fix_vendor_files
branch
from
34c97e7 to
f25b8d1
Compare
Member
Member
|
Backport provided in #21878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
With #21800, nrf5x_common pull vendor files from an external repo. The issue is that the target that copies the vendor files does so unconditionally, resulting in an update of the vendor files on every compilation, forcing
maketo rebuild mostly everything every time.This adds a flag to the
cpcommand to only copy the files over when the vendor ones are indeed newer.Testing procedure
Using some nrf-based board, compile some application (e.g.,
hello-world) twice usingQUIET=0. You should see that without this patch many objects are recompiled every time.Issues/PRs references
#21800