Skip to content

fix(#15): ERROR log when crawl upserts fewer than 50 campaigns #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jing-yilin merged 2 commits into from
Feb 27, 2026
Merged

fix(#15): ERROR log when crawl upserts fewer than 50 campaigns #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c3021a
fix(#15): ERROR log when crawl upserts fewer than 50 campaigns
Jing-yilin Feb 27, 2026
7721938
fix(#22): use distinct PID count for crawl sanity check
Jing-yilin Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions backend/internal/service/cron.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func (s *CronService) RunCrawlNow() error {
s.syncCategories()

upserted := 0
seenPIDs := make(map[string]struct{})
var allCampaigns []model.Campaign

for _, sortCfg := range crawlSorts {
Expand Down Expand Up @@ -104,6 +105,9 @@ func (s *CronService) RunCrawlNow() error {
log.Printf("Cron: upsert error: %v", result.Error)
} else {
upserted += len(campaigns)
for _, c := range campaigns {
seenPIDs[c.PID] = struct{}{}
}
allCampaigns = append(allCampaigns, campaigns...)
}
time.Sleep(500 * time.Millisecond)
Expand All @@ -112,6 +116,16 @@ func (s *CronService) RunCrawlNow() error {
}
log.Printf("Cron: crawl done, upserted %d campaigns", upserted)

// Sanity check: a full crawl across all categories should always yield
// at least some campaigns. Zero almost certainly means a parse failure
// (e.g. Kickstarter changed their HTML structure), not a genuinely empty site.
const minExpectedCampaigns = 50
if len(seenPIDs) < minExpectedCampaigns {
log.Printf("ERROR: crawl sanity check FAILED — only %d distinct campaigns seen (expected >=%d). "+
"Possible HTML structure change or ScrapingBee degradation. "+
"Check kickstarter_parser.go [data-project] selector.", len(seenPIDs), minExpectedCampaigns)
}

if len(allCampaigns) > 0 {
s.storeSnapshots(allCampaigns)
s.computeVelocity(allCampaigns)
Expand Down