fix: GORM column name mismatch — Campaign.PID saves as p_id instead of pid#25
Merged
Jing-yilin merged 1 commit intodevelopfrom Feb 27, 2026
Merged
fix: GORM column name mismatch — Campaign.PID saves as p_id instead of pid#25Jing-yilin merged 1 commit intodevelopfrom
Jing-yilin merged 1 commit intodevelopfrom
Conversation
GORM v2 converts PID → p_id by default, but the DB column and all upsert conflict clauses reference 'pid'. Adding gorm:"column:pid" forces the correct column name, unblocking all campaign inserts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All nightly crawl upserts fail with:
GORM v2 converts the field name
PID→p_id(snake_case), but the DB column ispidand allOnConflictclauses reference"pid".Fix
Add
gorm:"column:pid"explicit tag toCampaign.PIDso GORM uses the correct column name.Impact
ScrapingBee is successfully fetching data (confirmed in logs) — campaigns are just not being written to the DB. This fix unblocks all inserts.