Tweaking install_rms for Github Actions #2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conda's `info --envs` output now includes header lines with `*`. Filter out comment lines and use AWK to select the row containing `*`, extracting the environment name from the first field.
Member
Author
|
The regression test only failed because there are no recent "correct" results to compare with. This PR should fix that. 🐔🥚 |
JacksonBurns
approved these changes
Dec 2, 2025
Contributor
JacksonBurns
left a comment
JacksonBurns
left a comment
There was a problem hiding this comment.
look good! thanks for the patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
As descripbed in #2861
We need to restrict PythonCall to 0.9.28
https://github.com/JuliaPy/PythonCall.jl/releases
Description of Changes
I updated the Project.toml on the
for_rmgbranch of RMSReactionMechanismGenerator/ReactionMechanismSimulator.jl@7b4fc4f
This PR on RMG-Py is partly to test that fix.
But it also fixes another problem that crept into
install_rmsdue to how conda now lists environments.Testing
The whole point is to get the CI to work.
But I did run the new install_rms.sh locally, and it seemed to work.
Reviewer Tips
Check the CI logs