Fix regression tests coming back from the dead. #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it had been more than 15 runs (approx 15 days) since the last succesful baseline reference job, then all regression tests would fail. Furthermore, even the baseline reference job, would fail, making it impossible to get started again. Now, it checks the last 60 runs instead of the last 15, and it doesn't bother checking if you're running a reference job - so we should be able to resume even if there are no succesful results in the past.
JacksonBurns
approved these changes
Dec 2, 2025
Contributor
JacksonBurns
left a comment
JacksonBurns
left a comment
There was a problem hiding this comment.
Regression test is passing - thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
If it had been more than 15 runs (approx 15 days) since the last succesful baseline reference job, then all regression tests would fail. Furthermore, even the baseline reference job, would fail, making it impossible to get started again.
Description of Changes
Now, it checks the last 60 runs instead of the last 15, and it doesn't bother checking if you're running a reference job - so we should be able to resume even if there are no succesful results in the past.
Testing
Hopefully the proof is in the pudding.