[4.19] Change method of testing latest rhel versions used in data source #3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-2
requested review from
geetikakay and
rnetser
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
previously approved these changes
Dec 24, 2025
Collaborator
|
/lgtm |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 320 🏁 Script executed: Length of output: 10110 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 1191 🏁 Script executed: Length of output: 3553 🏁 Script executed: Length of output: 1220 🏁 Script executed: Length of output: 1781 🏁 Script executed: Length of output: 1171 🏁 Script executed: Length of output: 1908 🏁 Script executed: Length of output: 272 🏁 Script executed: Length of output: 1728 🧠 Learnings used |
OhadRevah
suggested changes
Dec 25, 2025
| ) | ||
| managed_data_source = rhel_instance_dict.spec.managedDataSource | ||
| assert managed_data_source, "spec.managedDataSource doesn't exists" | ||
| assert latest_rhel_release_versions_dict[managed_data_source] == image_reference_version |
Contributor
There was a problem hiding this comment.
Assert message in case of assertion error missing, and if managed_data_source is not a key in latest_rhel_release_versions_dict for some reason you will get a KeyError instead of clear assertion failure, maybe validate first that managed_data_source is a key in latest_rhel_release_versions_dict.
Contributor
Author
There was a problem hiding this comment.
This is a constant dictionary defined in latest_rhel_release_versions_dict. If a key is missing, it would indicate a serious issue and likely means an unverified PR was merged.
| ensure_exists=True, | ||
| ) | ||
| rhel_instance_dict = rhel_dic.instance | ||
| image_reference_version = get_image_version( |
Contributor
There was a problem hiding this comment.
get_image_version can return None, add an assert that it is not None or raise the exception in the function instead returning None.
What do you think?
Contributor
Author
There was a problem hiding this comment.
If it would return None then this would show on the failure comparison in the assertion message in the next lines:
assert latest_rhel_release_versions_dict[managed_data_source] == image_reference_version
##### Short description: Change method of testing latest rhel versions used in data source ##### More details: Manual cherry pick for RedHatQE#2737 - Added the `subtests` dependency needed on older version of python packages ##### What this PR does / why we need it: Remove use of osdb-info on tests Signed-off-by: rkishner <[email protected]>
RoniKishner
force-pushed
the
latest-test-419
branch
from
0178ea3 to
320d48b
Compare
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
approved these changes
Jan 5, 2026
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
|
|
||
| from tests.infrastructure.golden_images.update_boot_source.utils import ( | ||
| generate_data_import_cron_dict, | ||
| get_all_release_versions_from_docs, |
There was a problem hiding this comment.
Test Execution Plan
- Run smoke tests: False
tests/infrastructure/golden_images/update_boot_source/test_ssp_data_import_crons.py::test_updated_rhel_image
Rationale:
This PR removes the old osdb-info based test and replaces it with a new implementation that fetches RHEL versions directly from Red Hat documentation. Changes are isolated to the golden_images/boot_source testing module. Verified that no smoke tests use the new fixture latest_rhel_release_versions_dict or utility functions get_all_release_versions_from_docs() and get_image_version() - only files within tests/infrastructure/golden_images/update_boot_source/ reference these changes.
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 10198 🏁 Script executed: Length of output: 3553 🏁 Script executed: Length of output: 1220 🏁 Script executed: Length of output: 292 🏁 Script executed: Length of output: 1728 🧠 Learnings used |
Collaborator
|
/approve |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Change method of testing latest rhel versions used in data source
More details:
Manual cherry pick for
#2737
What this PR does / why we need it:
Remove use of osdb-info on tests