Skip to content

Refactor code generation templates and enhance test coverage #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor code generation templates and enhance test coverage #5293

wants to merge 1 commit into from

Conversation

@paulomorgado
Copy link
Contributor

@paulomorgado paulomorgado commented Oct 20, 2025 •
edited
Loading

Refactor code generation templates and enhance test coverage.

  • Added CSharpCompiler.AssertCompile assertions across multiple test files to ensure generated code compiles successfully.
  • Introduced new test cases for nullable path parameters, query string handling (arrays, dictionaries, deep objects), and OpenAPI specifications.
  • Refactored path and query parameter handling in Liquid templates for improved readability and correctness.
  • Generated auto-verified test outputs for new test cases.
  • Improved handling of constructor parameters in generated clients.

Addresses #5260 #4587 #5096

@paulomorgado paulomorgado mentioned this pull request Oct 20, 2025
Open
@paulomorgado
Copy link
Contributor Author

paulomorgado commented Oct 20, 2025

@RicoSuter, I noticed some tests override the .verified.txt file instead of generating a .received.txt file and comparing it in NSwag.CodeGeneration.CSharp.Tests.csproj. Is that intended?

@lahma
Copy link
Collaborator

lahma commented Oct 20, 2025

@RicoSuter, I noticed some tests override the .verified.txt file instead of generating a .received.txt file and comparing it in NSwag.CodeGeneration.CSharp.Tests.csproj. Is that intended?

It's for easier development, so you will see the changes when proposing a PR. Can't remember but this probably should only happen in development.

@paulomorgado
Copy link
Contributor Author

paulomorgado commented Oct 20, 2025

@RicoSuter, I noticed some tests override the .verified.txt file instead of generating a .received.txt file and comparing it in NSwag.CodeGeneration.CSharp.Tests.csproj. Is that intended?

It's for easier development, so you will see the changes when proposing a PR. Can't remember but this probably should only happen in development.

I don't like it. How can I change it?

@lahma
Copy link
Collaborator

lahma commented Oct 20, 2025

@RicoSuter, I noticed some tests override the .verified.txt file instead of generating a .received.txt file and comparing it in NSwag.CodeGeneration.CSharp.Tests.csproj. Is that intended?

It's for easier development, so you will see the changes when proposing a PR. Can't remember but this probably should only happen in development.

I don't like it. How can I change it?

I believe the switch is here:

https://github.com/RicoSuter/NSwag/blob/master/src/NSwag.CodeGeneration.Tests/VerifyHelper.cs#L44

@paulomorgado paulomorgado force-pushed the issues/5260 branch 3 times, most recently from a4330d4 to 001581a Compare October 21, 2025 13:45
@paulomorgado paulomorgado changed the title Fix template errors Refactor code generation templates and enhance test coverage Oct 21, 2025
@paulomorgado paulomorgado marked this pull request as ready for review October 21, 2025 13:51
@paulomorgado paulomorgado force-pushed the issues/5260 branch 7 times, most recently from 7588b31 to 1102b8c Compare October 22, 2025 09:25
@paulomorgado paulomorgado force-pushed the issues/5260 branch 2 times, most recently from 2006ab5 to 40ff6e5 Compare November 5, 2025 18:22
@paulomorgado
Refactor code generation templates and enhance test coverage.
15e4fab 
- Added `CSharpCompiler.AssertCompile` assertions across multiple test files to ensure generated code compiles successfully.
- Introduced new test cases for nullable path parameters, query string handling (arrays, dictionaries, deep objects), and OpenAPI specifications.
- Refactored path and query parameter handling in Liquid templates for improved readability and correctness.
- Generated auto-verified test outputs for new test cases.
- Improved handling of constructor parameters in generated clients.
@paulomorgado
Copy link
Contributor Author

paulomorgado commented Nov 6, 2025

Hi @RicoSuter,

All tests passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulomorgado @lahma