Add configurable API key support for Rule34Ripper #2145#2172
Open
apoorvdarshan wants to merge 2 commits intoRipMeApp:mainfrom
Open
Add configurable API key support for Rule34Ripper #2145#2172apoorvdarshan wants to merge 2 commits intoRipMeApp:mainfrom
apoorvdarshan wants to merge 2 commits intoRipMeApp:mainfrom
Conversation
Rule34.xxx now requires api_key and user_id for API access. Read credentials from config (rule34.api_key, rule34.user_id) and append them as query parameters. Warns users with setup instructions when credentials are missing.
itszechs
reviewed
Feb 20, 2026
src/main/java/com/rarchives/ripme/ripper/rippers/Rule34Ripper.java
Outdated
Show resolved
Hide resolved
itszechs
reviewed
Feb 20, 2026
src/main/java/com/rarchives/ripme/ripper/rippers/Rule34Ripper.java
Outdated
Show resolved
Hide resolved
- Extract DOMAIN and API_BASE_URL constants for the domain URL - Throw MalformedURLException in getAPIUrl() when credentials are missing - Update test to assert exception on missing credentials
Author
|
Addressed both review comments:
|
itszechs
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api_keyanduser_idfor DAPI access (#2145)rule34.api_key,rule34.user_id) and appends them as query parameters to API requestsloadConfig()/sendUpdateapproach)Test plan
testGetAPIUrlWithCredentials— verifies credentials appear in constructed API URLtestGetAPIUrlWithoutCredentials— verifies no credentials leak when unconfiguredtestShesFreakyRip→testRule34Riprule34.api_keyandrule34.user_idinrip.propertiesand rip a Rule34 tag URLCloses #2145