Open
Conversation
Adds initial application structure
Adds test requirements. Tweaks mappings and transformers.
Adds coveragerc file
Updates files to correct linting errors.
Fixes linting
Adds tests and fixtures
helrond
reviewed
Feb 17, 2026
Member
helrond
left a comment
helrond
left a comment
There was a problem hiding this comment.
Added some specific notes but a couple of global things:
- somehow all the pycache stuff found its way into version control, which makes things a lot messier than they should be. Can you get this stuff out of VCS?
- I think my next move would be to move the helpers that are still needed out of the
src/fetcherdirectory and then just delete all that stuff. - It looks to me like config handling is going to be somewhat complex in this app, so it might be worth thinking about what you want as an environment variable (i.e. what is specific to that particular lambda instance) and what will be the same across all instances (like credentials or common configs) and should consequently be pulled from SSM.
Removes old pycache files.
Removes iso639, implements pycountry, updates requirements, and updates dependency actions.
Accidentally passed online_pending along in transformation.
Removes unnecessary logic
Fixes linting and ignores boolean at start of line warning in tox (this is a modern accepted practice).
Member
Author
|
I also didn't include this from the old transformer because I wasn't sure we still needed it, since we're not saving anything, right? Or should I put this back into the transformer? |
Fixes transformer and test to actually use schemas (whoops).
Updates mappings and transformers to adhere strictly to old Pisces mappings as close as possible. Remove any normalization from transformers.
Implements functionality to get environment from ssm
Adds tests to cover more statements in transformers.
Updates test mappings. Removes old comment
Adds license and readme.
Tweaks transformer comments
Updates mapping tests to not call the environment import each function.
HaSistrunk
requested changes
Feb 26, 2026
Member
HaSistrunk
left a comment
HaSistrunk
left a comment
There was a problem hiding this comment.
Just a few minor things, I haven't delved deeply into the code. Are tests not running on your commits?
Cleans up deploy and gitignore and updates test_requirements
Fixes typo Co-authored-by: Hannah Sistrunk <hsistrunk@rockarch.org>
Fixes directory name of GitHub action workflows
p-galligan
had a problem deploying
to
development
GitHub Actions
Failure
Member
Author
Thanks! I had the wrong name for the workflows folder. And this uncovered an issue that I didn't know what happening locally. (My CLI had variables but the workflow environment doesn't, so tests fail. Gotta fix that) |
Fixes sns client to make it not require AWS during CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code and tests.
These aren't passing tests right now, and I think it has to do with some of the mappings. I also don't currently have tests for the lambda_handler.
You'll notice I have some environment setting. I didn't really get to mess with pulling from SSM, so that still needs work.
I think there are also some fixtures or schemas that could be removed and that aren't being used right now.
To Do:
Update code to pull environment variables from SSM for runtimeUpdate License and Readme documentationRemove unnecessary code from fetchers/helpers/mergers/resourcesWrite tests for lambda_handler functionIncrease code coverage for mappings and transformers