Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates configuration files and code generation settings to fix CI failures, reorganize dependencies, and align generated JSON serialization with global builder options.
- Added
qrcodeparameters to mock login methods to match API changes. - Reworked
pubspec.yaml, build scripts, and GitHub Actions workflow for consistent dependency versions and CI steps. - Simplified annotations and JSON serialization decorators, relying on global
build.yamloptions and updatedanalysis_options.yaml.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/tencent_kit_test.dart | Added optional qrcode flag to login and loginServerSide. |
| pubspec.yaml | Moved and updated dependencies; fixed repository URL. |
| lib/tencent_kit_platform_interface.dart | Added ignore for unnecessary library name. |
| lib/tencent_kit.dart | Added ignore for unnecessary library name. |
| lib/src/model/resp.g.dart | Adjusted JSON deserialization for num to int. |
| lib/src/model/resp.dart | Removed explicit field-rename annotations in favor of global settings. |
| lib/src/constant.dart | Converted classes to abstract final, added lint ignores. |
| example/pubspec.yaml | Streamlined metadata; updated Flutter SDK constraint. |
| example/lib/main.dart | Added const modifiers for widget instantiation. |
| example/lib/api/model/tencent_unionid_resp.g.dart | Adjusted JSON deserialization for consistency. |
| example/lib/api/model/tencent_api_resp.g.dart | Adjusted JSON deserialization for consistency. |
| example/build.yaml | Introduced global JSON builder options (any_map, field_rename). |
| example/.gitignore | Added pubspec.lock to ignore list. |
| build.yaml | Introduced global JSON builder options. |
| analysis_options.yaml | Switched to flutter_lints include and custom lint rules. |
| .github/workflows/build.yml | Added concurrency, branch filters, caching, and unified CI jobs. |
Comments suppressed due to low confidence (3)
.github/workflows/build.yml:93
- [nitpick] Consider aligning the
actions/checkoutandactions/setup-javaaction versions between theanalyzeandbuild_androidjobs (e.g., use@v4consistently) to simplify maintenance.
- uses: actions/checkout@v3
.github/workflows/build.yml:26
- [nitpick] The Android build job now only runs on Ubuntu. If platform-specific issues on Windows or macOS are a concern, consider restoring those platforms to the matrix to improve CI coverage.
matrix:
os: [ubuntu-latest]
test/tencent_kit_test.dart:45
- New
qrcodeparameter was added tologin. Please add or update tests to cover both default (false) andtruecases to ensure expected behavior.
bool qrcode = false,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.