feat: Bump eslint to v10

.changeset/large-paths-dance.md

@@ -0,0 +1,6 @@
+---
+'@sap-cloud-sdk/eslint-config': minor
+---
+
+[Compatibility Note] Replaced `eslint-plugin-import` with `eslint-plugin-import-x`.
+Please ensure that you have `eslint-plugin-import-x` installed.

build-packages/changesets-fixed-version-bump/package.json

@@ -23,7 +23,7 @@
     "@sap-cloud-sdk/test-util-build-internal": "workspace:^",
     "@vercel/ncc": "^0.38.4",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "memfs": "^4.57.2",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"

build-packages/check-license/index.ts

@@ -1,6 +1,6 @@
 import { execFileSync } from 'node:child_process';
 import { info, setFailed } from '@actions/core';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import bloakList from '@blueoak/list/index.json' with { type: 'json' };
 
 // Permissive FLOSS licenses are ok, see https://blueoakcouncil.org/list for details.

build-packages/check-license/package.json

@@ -20,7 +20,7 @@
   "devDependencies": {
     "@vercel/ncc": "^0.38.4",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"
   }

build-packages/check-pr/package.json

@@ -23,7 +23,7 @@
     "@sap-cloud-sdk/test-util-build-internal": "workspace:^",
     "@vercel/ncc": "^0.38.4",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "memfs": "^4.57.2",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"

build-packages/check-public-api/check-public-api.spec.ts

@@ -24,7 +24,7 @@ const {
   parseExportedObjectsInFile,
   regexExportedIndex,
   typeDescriptorPaths
-  // eslint-disable-next-line import/no-useless-path-segments
+  // eslint-disable-next-line import-x/no-useless-path-segments
 } = await import('./index.js');
 
 describe('check-public-api', () => {

build-packages/check-public-api/index.ts

@@ -10,9 +10,9 @@ import {
   readCompilerOptions,
   readIncludeExcludeWithDefaults,
   transpileDirectory
-  // eslint-disable-next-line import/no-internal-modules
+  // eslint-disable-next-line import-x/no-internal-modules
 } from '@sap-cloud-sdk/generator-common/dist/compiler.js';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import { defaultPrettierConfig } from '@sap-cloud-sdk/generator-common/dist/file-writer/create-file.js';
 import { getPackages } from '@manypkg/get-packages';
 import type { CompilerOptions } from 'typescript';

build-packages/check-public-api/package.json

@@ -27,7 +27,7 @@
     "@sap-cloud-sdk/test-util-build-internal": "workspace:^",
     "@vercel/ncc": "^0.38.4",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "memfs": "^4.57.2",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"

build-packages/get-changelog/package.json

@@ -19,7 +19,7 @@
   "devDependencies": {
     "@vercel/ncc": "^0.38.4",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"
   }

build-packages/merge-and-write-changelogs/package.json

@@ -20,7 +20,7 @@
   "devDependencies": {
     "@vercel/ncc": "^0.38.4",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"
   }

build-packages/test-utils/package.json

@@ -22,7 +22,7 @@
   },
   "devDependencies": {
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "prettier": "^3.8.1",
     "typescript": "~5.9.3"
   }

eslint.config.js

@@ -12,37 +12,42 @@ const compat = new FlatCompat({
   allConfig: js.configs.all
 });
 
+const localPlugin = {
+  rules: {
+    'no-uppercase-internal-tag': {
+      meta: { type: 'problem', schema: [] },
+      create(context) {
+        return {
+          Program() {
+            for (const comment of context.sourceCode.getAllComments()) {
+              if (comment.value.includes('@Internal')) {
+                context.report({
+                  loc: comment.loc,
+                  message:
+                    'You are not allowed to use @Internal. Please use @internal.'
+                });
+              }
+            }
+          }
+        };
+      }
+    }
+  }
+};
+
 module.exports = defineConfig([
+  {
+    plugins: { local: localPlugin },
+    rules: { 'local/no-uppercase-internal-tag': 'error' }
+  },
   {
     languageOptions: {
       globals: {
         ...globals.node,
         ...globals.jest
       },
       parser: tsParser,
-      sourceType: 'module',
-      parserOptions: {
-        project: {
-          extends: 'tsconfig.json',
-          include: ['**/*.ts'],
-
-          exclude: [
-            '**/*.d.ts',
-            '**/dist/**/*',
-            '**/node_modules/**/*',
-            'test-packages/test-services*/**/*',
-            'test-packages/test-services-e2e/**/*',
-            'test-packages/memory-tests/sdk-v1/test-service/*',
-            'test-packages/memory-tests/sdk-canary/test-service/*',
-            'build-packages/check-pr/lib/**',
-            'build-packages/get-changelog/lib/**',
-            'packages/rest-generator/test/test-services/**/*',
-            'test-resources/cli/**/*',
-            '**/test-output/**',
-            '**/README.md'
-          ]
-        }
-      }
+      sourceType: 'module'
     },
     extends: compat.extends('@sap-cloud-sdk'),
     rules: {
@@ -55,7 +60,7 @@ module.exports = defineConfig([
             'Enums are weird in TypeScript. Prefer union types or const objects instead.'
         }
       ],
-      'import/no-internal-modules': [
+      'import-x/no-internal-modules': [
         'error',
         {
           allow: ['@sap-cloud-sdk/**/internal', '@sap-cloud-sdk/**/internal.js']
@@ -85,7 +90,7 @@ module.exports = defineConfig([
   {
     files: ['**/test/**/*', '**/*.spec.ts'],
     rules: {
-      'import/no-internal-modules': 'off',
+      'import-x/no-internal-modules': 'off',
       'no-unused-expressions': 'off',
       'jsdoc/require-jsdoc': 'off'
     }
@@ -102,7 +107,7 @@ module.exports = defineConfig([
       'packages/connectivity/src/scp-cf/token-accessor.ts'
     ],
     rules: {
-      'import/no-internal-modules': [
+      'import-x/no-internal-modules': [
         'error',
         {
           allow: [

package.json

@@ -72,7 +72,7 @@
     "axios": "^1.15.0",
     "cross-env": "10.1.0",
     "depcheck": "^1.4.7",
-    "eslint": "^9.39.2",
+    "eslint": "^10.2.1",
     "execa": "^5.0.0",
     "glob": "^13.0.6",
     "globals": "^17.4.0",

packages/connectivity/internal.d.ts

@@ -1,3 +1,3 @@
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 export * from './dist/internal';
 // # sourceMappingURL=internal.d.ts.map

packages/connectivity/src/http-agent/http-agent.spec.ts

@@ -2,7 +2,7 @@ import { mockFsWithMemfs } from '@sap-cloud-sdk/test-util-internal/fs-mocker';
 
 mockFsWithMemfs(jest);
 
-// eslint-disable-next-line import/order
+// eslint-disable-next-line import-x/order
 import { X509Certificate } from 'node:crypto';
 import { jest } from '@jest/globals';
 import { vol } from 'memfs';

packages/connectivity/src/http-agent/http-agent.ts

@@ -4,25 +4,25 @@ import https from 'node:https';
 import * as jks from 'jks-js';
 import { createLogger, last } from '@sap-cloud-sdk/util';
 /* Careful the proxy imports cause circular dependencies if imported from scp directly */
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import { getProtocolOrDefault } from '../scp-cf/get-protocol';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import { Cache, hashCacheKey } from '../scp-cf/cache';
 import {
   addProxyConfigurationInternet,
   getProxyConfig,
   proxyStrategy
-  // eslint-disable-next-line import/no-internal-modules
+  // eslint-disable-next-line import-x/no-internal-modules
 } from '../scp-cf/destination/http-proxy-util';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import { registerDestinationCache } from '../scp-cf/destination/register-destination-cache';
 import type {
   Destination,
   DestinationCertificate,
   HttpDestination
-  // eslint-disable-next-line import/no-internal-modules
+  // eslint-disable-next-line import-x/no-internal-modules
 } from '../scp-cf/destination';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import type { BasicProxyConfiguration } from '../scp-cf/connectivity-service-types';
 import type { HttpAgentConfig, HttpsAgentConfig } from './agent-config';
 

packages/connectivity/src/scp-cf/authorization-header.ts

@@ -4,7 +4,7 @@ import {
   encodeBase64,
   pickValueIgnoreCase
 } from '@sap-cloud-sdk/util';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import { sanitizeDestination } from './destination/destination';
 import type {
   AuthenticationType,

packages/connectivity/src/scp-cf/destination/destination-from-registration.spec.ts

@@ -2,7 +2,7 @@ import { mockFsWithMemfs } from '@sap-cloud-sdk/test-util-internal/fs-mocker';
 
 mockFsWithMemfs(jest);
 
-// eslint-disable-next-line import/order
+// eslint-disable-next-line import-x/order
 import { X509Certificate } from 'node:crypto';
 import { jest } from '@jest/globals';
 import { vol } from 'memfs';

packages/connectivity/src/scp-cf/destination/register-destination-cache.spec.ts

@@ -2,7 +2,7 @@ import { mockFsWithMemfs } from '@sap-cloud-sdk/test-util-internal/fs-mocker';
 
 mockFsWithMemfs(jest);
 
-// eslint-disable-next-line import/order
+// eslint-disable-next-line import-x/order
 import { X509Certificate } from 'node:crypto';
 import { jest } from '@jest/globals';
 import { vol } from 'memfs';

packages/connectivity/src/scp-cf/environment-accessor/service-credentials.ts

@@ -1,5 +1,5 @@
 import { createLogger } from '@sap-cloud-sdk/util';
-// eslint-disable-next-line import/no-internal-modules
+// eslint-disable-next-line import-x/no-internal-modules
 import { audiences, decodeJwt } from '../jwt/jwt';
 import { getServiceBindings } from './service-bindings';
 import type { JwtPayload } from '../jsonwebtoken-type';

packages/eslint-config/README.md

@@ -37,7 +37,7 @@ or if you want to combine this configuration with others:
 }
 ```
 
-This configuration depends on plugins "eslint-plugin-import" and "eslint-plugin-unused-imports", which need to be installed in your project.
+This configuration depends on plugins "eslint-plugin-import-x" and "eslint-plugin-unused-imports", which need to be installed in your project.
 
 ESlint merges these shareable configs with your configuration.
 Any rule configured in your `.eslintrc.js` will overwrite the setting for this rule in shareable configs.