Adding HPX backend (train,predict and tests) based on hpx::for_each and hpx::experimental::for_loop #70

constracktor · 2024-11-07T16:40:56Z

Adding HPX backend on hpx::for_each and hpx::experimental::for_loop
Includes:

train, predict with HPX backend
tests for HPX backend

src/plssvm/backends/HPX/detail/utility.cpp

src/plssvm/backends/HPX/CMakeLists.txt

tests/backends/HPX/CMakeLists.txt

tests/backends/HPX/detail/utility.cpp

src/main_train.cpp

src/main_predict.cpp

include/plssvm/backends/HPX/kernel/cg_implicit/kernel_matrix_assembly_blas.hpp

include/plssvm/backends/HPX/kernel/cg_explicit/kernel_matrix_assembly.hpp

include/plssvm/backends/HPX/detail/utility.hpp

tests/backend_types.cpp

breyerml · 2024-11-08T11:03:20Z

Missing changes:

add the HPX CSVM to the Python bindings and update the Python bindings README accordingly.
add HPX to the CMake install components
add HPX as CMake preset
update the README to add the HPX backend
add the HPX header to the .clang-format file and reformat all files accordingly
add the HPX directories to the docs/resources/dirs.dox file
add the HPX namespace documentation to the core.hpp file
add HPX as possible backend to the detail/cmd/parser_train.hpp and detail/cmd/parser_predict.hpp backend variable documentation
add the HPX backend flag to the TEST_P(ParserTrainBackend, parsing) and TEST_P(ParserPredictBackend, parsing) tests

include/plssvm/core.hpp

constracktor · 2024-11-12T00:40:41Z

@breyerml I think except formatting the code with clang-format I checked everything on the list.

breyerml · 2024-11-12T14:06:05Z

@breyerml I think except formatting the code with clang-format I checked everything on the list.

I've updated the develop branch with an auto-formatting workflow. Please rebase this branch and fix the formatting errors accordingy.

breyerml · 2024-11-12T17:11:44Z

What would be the minimum HPX version that we need that supports all used features?

breyerml · 2024-11-13T08:34:12Z

	3967 - HPXCSVM.blas_level_3_kernel_explicit (Failed)
	3968 - HPXCSVM.calculate_w (Failed)
	5409 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/linear.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)0> >> (Failed)
	5410 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/linear.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)0> >> (Failed)
	5411 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/linear.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)0> >> (Failed)
	5412 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/polynomial.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)1> >> (Failed)
	5413 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/polynomial.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)1> >> (Failed)
	5414 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/polynomial.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)1> >> (Failed)
	5415 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/rbf.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)2> >> (Failed)
	5416 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/rbf.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)2> >> (Failed)
	5417 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/rbf.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)2> >> (Failed)
	5418 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/sigmoid.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)3> >> (Failed)
	5419 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/sigmoid.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)3> >> (Failed)
	5420 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/sigmoid.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)3> >> (Failed)
	5421 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/laplacian.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)4> >> (Failed)
	5422 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/laplacian.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)4> >> (Failed)
	5423 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/laplacian.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)4> >> (Failed)
	5424 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/chi_squared.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)5> >> (Failed)
	5425 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/chi_squared.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)5> >> (Failed)
	5426 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/chi_squared.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)5> >> (Failed)

With HPX 1.9.1 and GCC 12.2.0 all these tests fail due to a Segmentation Fault.

breyerml · 2024-11-13T09:00:11Z

/data/scratch/breyerml/PLSSVM_hpx/docs/resources/dirs.dox:333: warning: No matching directory found for command \dir include/plssvm/backends/hpx/
/data/scratch/breyerml/PLSSVM_hpx/docs/resources/dirs.dox:345: warning: No matching directory found for command \dir include/plssvm/backends/hpx/detail/
/data/scratch/breyerml/PLSSVM_hpx/docs/resources/dirs.dox:357: warning: No matching directory found for command \dir include/plssvm/backends/hpx/kernel/
/data/scratch/breyerml/PLSSVM_hpx/docs/resources/dirs.dox:369: warning: No matching directory found for command \dir include/plssvm/backends/hpx/kernel/cg_explicit/
/data/scratch/breyerml/PLSSVM_hpx/docs/resources/dirs.dox:381: warning: No matching directory found for command \dir include/plssvm/backends/hpx/kernel/cg_implicit/

When enabling the documentation target, these warnings appear -> the directory names should be HPX instead of hpx.

Additionally, please document the constructor and destructor for the scope_guard struct.

breyerml · 2024-11-13T09:13:43Z

HPX is missing in the cmake/plssvm/plssvmConfig.cmake.in file.

breyerml · 2024-11-13T09:16:08Z

HPX requires a call to the respective initialization functions. How is this or can this be handled in the Python bindings?

constracktor · 2024-11-13T10:08:00Z

What would be the minimum HPX version that we need that supports all used features?

HPX version 1.9.0 since hpx::post was introduced here. We could try to use something different to support older versions. But I do not think that is necessary.

breyerml · 2024-11-13T11:59:58Z

What would be the minimum HPX version that we need that supports all used features?

HPX version 1.9.0 since hpx::post was introduced here. We could try to use something different to support older versions. But I do not think that is necessary.

Does it make sense than to change find_package(HPX) to find_package(HPX 1.9.0) if this is support by HPX's CMake integration?

constracktor · 2024-11-13T17:18:06Z

	3967 - HPXCSVM.blas_level_3_kernel_explicit (Failed)
	3968 - HPXCSVM.calculate_w (Failed)
	5409 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/linear.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)0> >> (Failed)
	5410 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/linear.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)0> >> (Failed)
	5411 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/linear.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)0> >> (Failed)
	5412 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/polynomial.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)1> >> (Failed)
	5413 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/polynomial.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)1> >> (Failed)
	5414 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/polynomial.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)1> >> (Failed)
	5415 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/rbf.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)2> >> (Failed)
	5416 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/rbf.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)2> >> (Failed)
	5417 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/rbf.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)2> >> (Failed)
	5418 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/sigmoid.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)3> >> (Failed)
	5419 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/sigmoid.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)3> >> (Failed)
	5420 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/sigmoid.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)3> >> (Failed)
	5421 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/laplacian.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)4> >> (Failed)
	5422 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/laplacian.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)4> >> (Failed)
	5423 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/laplacian.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)4> >> (Failed)
	5424 - HPXCSVMKernelFunction.assemble_kernel_matrix_explicit<HPXCSVMKernelFunction/chi_squared.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)5> >> (Failed)
	5425 - HPXCSVMKernelFunction.blas_level_3_kernel_implicit<HPXCSVMKernelFunction/chi_squared.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)5> >> (Failed)
	5426 - HPXCSVMKernelFunction.predict_values<HPXCSVMKernelFunction/chi_squared.  # TypeParam = util::test_parameter<util::type_list<>,util::value_list<(plssvm::kernel_function_type)5> >> (Failed)

With HPX 1.9.1 and GCC 12.2.0 all these tests fail due to a Segmentation Fault.

This is related to the hpx::execution::par(_unseq) policy. When using hpx::execution::seq all tests pass. However, the parallel execution policy does not segfault for the plssvm-train(predict) executables.

constracktor · 2024-11-13T21:19:22Z

@breyerml I think except formatting the code with clang-format I checked everything on the list.

I've updated the develop branch with an auto-formatting workflow. Please rebase this branch and fix the formatting errors accordingy.

Code is now formatted. The git patch artifact works like a charm!

constracktor · 2024-11-13T21:20:38Z

HPX requires a call to the respective initialization functions. How is this or can this be handled in the Python bindings?

HPX runtime functionalities are added to the new environment.hpp dummy structure.

README.md

bindings/Python/README.md

include/plssvm/environment.hpp

src/main_train.cpp

src/main_predict.cpp

tests/main.cpp

tests/backends/HPX/CMakeLists.txt

tests/main.cpp

tests/backends/HPX/CMakeLists.txt

tests/hpx_main.cpp

breyerml reviewed Nov 8, 2024

View reviewed changes

tests/backend_types.cpp Show resolved Hide resolved

constracktor force-pushed the hpx_start branch 2 times, most recently from ecb1323 to e305450 Compare November 9, 2024 11:24

breyerml reviewed Nov 11, 2024

View reviewed changes

include/plssvm/core.hpp Show resolved Hide resolved

constracktor force-pushed the hpx_start branch from 95aa7a5 to f5349b0 Compare November 11, 2024 15:47

constracktor force-pushed the hpx_start branch from b73a8d9 to d50c4f0 Compare November 13, 2024 10:03

constracktor force-pushed the hpx_start branch 4 times, most recently from 225ea27 to 292f889 Compare November 13, 2024 21:15

breyerml reviewed Nov 14, 2024

View reviewed changes

README.md Show resolved Hide resolved

bindings/Python/README.md Show resolved Hide resolved

include/plssvm/environment.hpp Show resolved Hide resolved

src/main_train.cpp Show resolved Hide resolved

src/main_train.cpp Show resolved Hide resolved

src/main_predict.cpp Show resolved Hide resolved

constracktor force-pushed the hpx_start branch from 292f889 to f0c5ab0 Compare November 14, 2024 12:32

constracktor added 4 commits November 18, 2024 14:17

Fix OpenMP typo

c857e12

Initial commit HPX backend

124a779

Add HPX as backend type

4a76248

Initial src for HPX backend

0902c04

constracktor added 12 commits November 18, 2024 14:17

Concretize the minimum required HPX version

444afa1

Fix wrong path to HPX backend

958bfce

Comment HPX Scope Guard struct

b2ef7e0

Add HPX as supported component

0196fab

Add minimum HPX version

ba96502

Add HPX runtime to environment header

5210fee

Remove HPX Scope Guard as now obsolete

d220f4d

Cleanup main_train.cpp after rebase error

02b400e

Add HPX backend to commandline output and set correct priority

af4c5f6

Add note to manage HPX runtime in Python

fdbf38c

Add HPX to backend vector if used

66ea031

Minor clang-format changes

148f0ba

constracktor force-pushed the hpx_start branch from 510e308 to 148f0ba Compare November 18, 2024 13:40

constracktor added 5 commits November 18, 2024 15:38

Add HPX runtime to rewritten environment header

2024484

Major clang format changes after rebase

4a3e3d5

Adjust tests/main.cpp to new environment.hpp

30d9d64

Add HPX combination types in tests

d296825

HPX runtime workaround for tests

545e0fb

breyerml reviewed Nov 20, 2024

View reviewed changes

tests/main.cpp Outdated Show resolved Hide resolved

constracktor force-pushed the hpx_start branch from e185f72 to 9bbed73 Compare November 25, 2024 18:19

Separate main for HPX tests

e74f80f

constracktor force-pushed the hpx_start branch from 9bbed73 to e74f80f Compare November 25, 2024 18:27

breyerml reviewed Nov 26, 2024

View reviewed changes

tests/backends/HPX/CMakeLists.txt Show resolved Hide resolved

tests/main.cpp Show resolved Hide resolved

constracktor added 4 commits November 26, 2024 18:48

Remove unused header

db44766

Adjust accuracy for failing tests

192a9bd

Remove unnecessary HPX lib check

7ac367d

Fix HPX scope guard

e738e2a

breyerml reviewed Nov 26, 2024

View reviewed changes

tests/backends/HPX/CMakeLists.txt Show resolved Hide resolved

tests/hpx_main.cpp Show resolved Hide resolved

Make HPX package required

c5c7dab

breyerml merged commit 385b9b4 into SC-SGS:develop Nov 28, 2024
2 checks passed

Adding HPX backend (train,predict and tests) based on hpx::for_each and hpx::experimental::for_loop #70

Adding HPX backend (train,predict and tests) based on hpx::for_each and hpx::experimental::for_loop #70

Uh oh!

Conversation

constracktor commented Nov 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

breyerml commented Nov 8, 2024

Uh oh!

Uh oh!

constracktor commented Nov 12, 2024

Uh oh!

breyerml commented Nov 12, 2024

Uh oh!

breyerml commented Nov 12, 2024

Uh oh!

breyerml commented Nov 13, 2024

Uh oh!

breyerml commented Nov 13, 2024

Uh oh!

breyerml commented Nov 13, 2024

Uh oh!

breyerml commented Nov 13, 2024

Uh oh!

constracktor commented Nov 13, 2024

Uh oh!

breyerml commented Nov 13, 2024

Uh oh!

constracktor commented Nov 13, 2024

Uh oh!

constracktor commented Nov 13, 2024

Uh oh!

constracktor commented Nov 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants