Add Q-matrix preprocessing permutation#33
Open
bernalde wants to merge 2 commits into
Open
Conversation
bernalde
commented
May 15, 2026
Member
Author
There was a problem hiding this comment.
No blocking issues found. I inspected the PR diff, surrounding solver/Solution/JuMP code, tests, docs, README, and CI workflows. The implementation keeps caller-facing bit order stable while using the permuted tensor order internally, and the one-variable fallback is consistent with the existing API surface.
Tests run locally:
- julia +1.12 --project=. -e 'using Pkg; Pkg.test()' passed.
- julia +1.12 --project=docs/ docs/make.jl passed.
- julia +1.12 --project=test -e 'push!(LOAD_PATH, pwd()); using Test, TenSolver, JuMP, LinearAlgebra; ...' targeted preprocessing/JuMP/one-variable smoke passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solutionsamples and probability checks.preprocessoptimizer attribute through the QUBODrivers/JuMP solve path.Tests run
julia +1.12 --project=. -e 'using Pkg; Pkg.test()'- passed.julia +1.12 --project=docs/ docs/make.jl- passed.julia +1.10 -e 'import Pkg; Pkg.activate(; temp=true); Pkg.develop(path=pwd()); Pkg.test("TenSolver"; coverage=true, julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false, allow_reresolve=true)'- passed.Notes about tests not run
julia --project=. -e 'using Pkg; Pkg.test()'was attempted first, but the default local Julia is 1.11.5 while the checked-out manifest was resolved with Julia 1.12.6, causing Pkg to fail before package code loaded with a missingOpenSSL_jllsource error. The suite was rerun successfully withjulia +1.12.julia +1.10 --project=. -e 'import Pkg; Pkg.test(; coverage=true, julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false, allow_reresolve=true)'hit the same local manifest mismatch. The Julia 1.10 test was rerun from a temporary environment that develops this checkout, matching CI's resolved QUBODrivers v0.3.4 path without mutating tracked manifests.Closes #12