Document SpinGlassPEPS integration architecture#41
Conversation
bernalde
left a comment
There was a problem hiding this comment.
Blocking issues: none found in the changed documentation.
Nonblocking issues: none found.
Questions: none.
Tests run and outcomes:
julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'passed.julia --project=docs/ docs/make.jl localpassed, including doctests and cross-reference checks.julia +1.12 --project=. -e 'using Pkg; Pkg.test()'passed.julia +1.10 --project=. -e 'using Pkg; Pkg.test()'did not reach test execution locally because the root manifest was resolved with Julia 1.12.6 and Pkg could not locateOpenSSL_jllunder Julia 1.10.11.- The PR CI LTS Ubuntu job is failing in the existing QUBODrivers fixed-variable suite when
TenSolver.Optimizeris exercised on a one-variable model;ITensorMPS.dmrgerrors that system size 1 is unsupported. The documentation job passed.
Merge as-is: not while the required test workflow is red. I did not find a PR-diff issue that needs an inline comment, but this should get a green test run or an explicit maintainer decision on the unrelated LTS failure before merge.
|
Reviewed the PR feedback. Commits pushed:
Main changes made:
Tests run:
Comments intentionally not addressed:
Remaining risks or follow-up:
|
|
Pushed the requested CI fix. Commits pushed:
Main changes made:
Tests run:
Comments intentionally not addressed:
Remaining risks:
|
bernalde
left a comment
There was a problem hiding this comment.
GitHub rejected an APPROVE review from this authenticated account because it is the PR author, so this is submitted as a COMMENT review. The maintainer recommendation is still merge-ready as-is.
- Blocking issues: none.
- Nonblocking issues: none.
- Questions: none.
- Tests run and outcomes:
git diff --check origin/main...HEAD: passed.julia +1.12 --project=. -e 'using Test, Random, LinearAlgebra, TenSolver; include("test/utils.jl"); include("test/qubo.jl")': passed, 82 tests.julia --project=docs/ docs/make.jl local: passed.julia +1.12 --project=. -e 'using Pkg; Pkg.test()': passed.gh pr checks 41 --watch --fail-fast: all PR checks passed across Julia 1, LTS, prerelease, docs build, and Documenter deploy.
- Merge recommendation: merge-ready as-is.
bernalde
left a comment
There was a problem hiding this comment.
GitHub rejected an APPROVE review from this authenticated account because it is the PR author, so this is submitted as a COMMENT review. The maintainer recommendation is still merge-ready as-is.
Blocking issues: none.
Nonblocking issues: none.
Questions: none.
Tests run and outcomes:
git diff --check origin/main...HEAD: passed.julia --project=. -e 'using Test, Random, LinearAlgebra, TenSolver; include("test/utils.jl"); include("test/qubo.jl")': passed, 82 tests.julia --project=. -e 'using Pkg; Pkg.test()': passed on Julia 1.11.5.julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()': passed.julia --project=docs/ docs/make.jl local: passed.julia +1.10 --startup-file=no -e 'using Pkg; Pkg.activate(; temp=true); Pkg.develop(PackageSpec(path=pwd())); Pkg.add(["Aqua", "JuMP", "QUBODrivers"]); using Test, Random, LinearAlgebra, TenSolver; include("test/utils.jl"); include("test/qubo.jl"); include("test/external.jl")': passed; QUBO 82/82, QUBODrivers 129/129, Aqua 11/11.- One-variable smoke checks for integer QUBO input and single-variable DynamicPolynomials input: passed.
Merge as-is: yes. I found no actionable correctness, API, documentation, or maintainability issues in this PR.
Summary
Tests run
julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'- passed.julia --project=docs/ docs/make.jl local- passed, including Documenter doctests.julia +1.12 --project=. -e 'using Pkg; Pkg.test()'- passed.julia +1.12 --project=. -e 'using Test, Random, LinearAlgebra, TenSolver; include("test/utils.jl"); include("test/qubo.jl")'- passed, 82 tests.julia +1.10 --startup-file=no -e 'using Pkg; Pkg.activate(; temp=true); Pkg.develop(PackageSpec(path=pwd())); Pkg.add(["Aqua", "JuMP", "QUBODrivers"]); using Test, TenSolver; include("test/external.jl")'- passed, including QUBODrivers and Aqua.Notes
julia --project=. -e 'using Pkg; Pkg.test()'with the default local Julia 1.11.5 did not reach test execution because the local ignored root manifest was resolved with Julia 1.12.6 and Pkg could not locateOpenSSL_jllfor the older active Julia. The LTS-relevant external test was therefore run in a fresh Julia 1.10 temporary environment.Closes #35