Open
Conversation
jstvz
requested changes
Jun 20, 2024
| security_type: SecurityType = SecurityType.FULL | ||
| apex_compile_type: Optional[ApexCompileType] = None | ||
| upgrade_type: Optional[UpgradeType] = None | ||
| skip_handlers: SkipHandlers = SkipHandlers.FEATURE_ENFORCEMENT |
Contributor
There was a problem hiding this comment.
±: We don't want to silently change behavior, so it shouldn't be a default. Instead, it should be an optional Option set to None.
Comment on lines
+92
to
+93
| if "skip_handlers" in task_options: | ||
| options.skip_handlers = SkipHandlers(task_options["skip_handlers"]) |
Contributor
There was a problem hiding this comment.
💭: Implementation note: The sf flag allows multiple values and combines them into a comma-separated string for PackageInstallCreateRequest. We don't need to do this here now, but we might need to if they add more SkipHandlers in the future.
Author
There was a problem hiding this comment.
Added a comment for future consideration.
Author
|
@jstvz Any more changes required for this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipHandlersadded inPackageInstallRequeststarting from API Version 61.0 (Summer '24)