RTPStream: Deduplicate logic for audio/video debug files#846
Merged
lemenkov merged 1 commit intoSIPp:masterfrom Jan 31, 2026
Merged
RTPStream: Deduplicate logic for audio/video debug files#846lemenkov merged 1 commit intoSIPp:masterfrom
lemenkov merged 1 commit intoSIPp:masterfrom
Conversation
06ad74e to
3c57706
Compare
lemenkov
approved these changes
Jan 31, 2026
Member
There was a problem hiding this comment.
Overall looks good. perhaps we could slightly improve it (in a separate PR) - Claude insists there is a TOCTOU issue here:
Race condition (theoretical, not practical)
printHex() and printVector() check fp before acquiring the mutex but use it after:
if (!fp || !note || !string || !rtpcheck_debug) // no lock
return;
std::lock_guard lock(mutex);
fprintf(fp, ...); // fp could be null if close() ran in betweenIn practice this can't fire because close() is only called from rtpstream_shutdown() after all threads are joined. But it's technically a TOCTOU race. A quick if (!fp) return; after the lock acquisition would make it bulletproof.
Same pattern in open() and close() — the outer if (fp) is unsynchronized. Again harmless in practice since open/close don't race with each other given SIPp's lifecycle.
Contributor
Author
|
@lemenkov I prefer rebase/squash over merge. Disabled merge in settings. If you dislike it, let's discuss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.