Remove legacy endianshim.h compatibility layer#852
Merged
orgads merged 1 commit intoSIPp:masterfrom Feb 10, 2026
Merged
Conversation
Replace the endianshim.h header with direct platform-specific includes in prepare_pcap.c, using CMake-detected HAVE_* macros. The old shim contained compatibility code for platforms with unknown support status: - HP-UX (_HPUX_SOURCE) - Solaris (USG) - glibc < 2.9 (predates 2008) The le16toh symbol existence checks (HAVE_DECL_LE16TOH) are removed as they were only needed for ancient glibc where endian.h existed but the macro didn't. If the header exists, the macro exists. Supported platforms now use: - Linux: <endian.h> - macOS: <libkern/OSByteOrder.h> - BSD: <sys/endian.h> Also simplify config.h.in by removing @var@ suffixes from boolean cmakedefines where they're unnecessary. Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Assisted-by: Claude (Anthropic) <https://claude.ai>
orgads
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the endianshim.h header with direct platform-specific includes in prepare_pcap.c, using CMake-detected HAVE_* macros. The old shim contained compatibility code for platforms with unknown support status:
The le16toh symbol existence checks (HAVE_DECL_LE16TOH) are removed as they were only needed for ancient glibc where endian.h existed but the macro didn't. If the header exists, the macro exists.
Supported platforms now use:
Also simplify config.h.in by removing @var@ suffixes from boolean cmakedefines where they're unnecessary.
Assisted-by: Claude (Anthropic) https://claude.ai