Skip to content

Enhanced z3 version check - now checking version used by smlp#136

Open
mdmitry1 wants to merge 10 commits into
masterfrom
smlp_z3_version
Open

Enhanced z3 version check - now checking version used by smlp#136
mdmitry1 wants to merge 10 commits into
masterfrom
smlp_z3_version

Conversation

@mdmitry1
Copy link
Copy Markdown
Collaborator

#!/usr/bin/env python3.11
from ctypes import cdll, c_char_p
from smlp import core
libsmlp=cdll.LoadLibrary(core.libsmlp.__file__)
z3_version=libsmlp.Z3_get_full_version
z3_version.restype=c_char_p
print(z3_version().decode())

@mdmitry1 mdmitry1 added the enhancement New feature or request label May 13, 2026
Copy link
Copy Markdown
Collaborator Author

@mdmitry1 mdmitry1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes

@fbrausse
Copy link
Copy Markdown
Collaborator

Re-loading libsmlp.*.so via cdll will never officially be supported as SMLP API usage. Irrespective of that I don't mind using that for your own checks. I don't understand why it needs to be part of the repository. Also, the printed version is not checked against anything, so what is the point of this z3_version.py script?

@mdmitry1
Copy link
Copy Markdown
Collaborator Author

Regression on Ubuntu 24.04 passed for both wheel types:

  1. GitHub build
  2. Docker build

and for both install types:

  1. Virtual environment
  2. sudo

@mdmitry1
Copy link
Copy Markdown
Collaborator Author

mdmitry1 commented May 13, 2026

I'm checking z3 version manually.
If needed, can check compare it to expected version.
With regards to repository - this is the way README.md installation instructions are validated.

@mdmitry1 mdmitry1 self-assigned this May 15, 2026
Copy link
Copy Markdown
Collaborator Author

@mdmitry1 mdmitry1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified PR changes after merge with master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants