Conversation
ahmed-irfan
requested changes
Nov 10, 2025
Member
ahmed-irfan
left a comment
ahmed-irfan
left a comment
There was a problem hiding this comment.
can you please also add tests
Ovascos
force-pushed
the
smt-rat-fixes
branch
from
d345569 to
4e2b911
Compare
and added missing `Value(int)` constructor.
Contributor
Author
|
Tests for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes provided by the SMT-RAT team (thanks to @derjasper):
lp_polynomial_constraint_evaluate_subs: new function to evaluate a polynomial to a rational and compare the sign.lp_polynomial_roots_isolate: improve performance by calculating the reductum with the evaluated polynomial.lp_variable_db_add_variable: fixes a bug in the variable db size calculation.