Fix downward migrations / allow initialization without both ClientSettings if ConnectionString and DatabaseName have been provided #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two issues:
When downgrading the database version by setting
MongoMigrationSettings.DatabaseMigrationVersion, theDatabaseMigrationRunnerwould run not only migrations with a version that is smaller thancurrentVersion, but any version that is not equal totoVersion.On .Net core, when you're providing a
ConnectionStringandDatabasein theMongoMigrationSettings, initialization would fail because of two checks thatMongoMigrationSettingsincorrectly enforce that bothMongoMigrationSettings.ConnectionStringandMongoMigrationSettings.ClientSettingsbe populated. Subsequent code shows that this isn't what was intended - initialization was prepared for both cases: when there's only aConnectionStringand when there's onlyClientSettings. Hence I changed the initialization checks accordingly to allow initialization if only one ofConnectionString/ClientSettingsis provided inMongoMigrationSettings.