[autobackport: sssd-2-11] Tests: Handle SELinux in proxy provider tests #8369
Conversation
Tests using nslcd fail under SELinux enforcing due to missing policies for test-only nss-pam-ldapd configuration. Add context manager to temporarily set permissive mode for affected tests. Reviewed-by: Jakub Vávra <jvavra@redhat.com> (cherry picked from commit 8b0071c)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a backport that addresses test failures in an SELinux enforcing environment by temporarily setting SELinux to permissive mode for the affected tests. The changes in src/tests/system/tests/test_proxy.py correctly use a context manager (client.host.selinux_permissive_for_test) to wrap the test bodies. This approach is sound and effectively resolves the issue. The implementation is correct and I have no further suggestions.
|
The pull request was accepted by @jakub-vavra-cz with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
3 participants
This is an automatic backport of PR#8348 Tests: Handle SELinux in proxy provider tests to branch sssd-2-11, created by @aborah-sudo.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
8b0071c - Tests: Handle SELinux in proxy provider tests
Backported commits
Original Pull Request Body
Tests using nslcd fail under SELinux enforcing due to missing policies for test-only nss-pam-ldapd configuration. Add context manager to temporarily set permissive mode for affected tests.