Conversation
Renamed the stuart module to default and seperated the gravity parameters into their own file. Also some comments in vacio as part of some reading.
Also mpi=off.
We now write all arrays in 3D, always. The dataset creation code is now in vacio.t because of a bug in gcc-fortran, or at least what looks like one.
It seems at this point that the bug is not in the dataset reading (as this appears to be working, giving the same means as python), it seems that the non-fullini read is also not working with the binary input.
Why is SAC not running when no ghost cells are specified?!
There seems to now be other issues, firstly with gdfout.
Need some robust code, but it seems to be working.
Currently not working is dealing with making gdf files not add the processor rank to the filename.
The main dataset write now seems to be working. However domain_left_edge and domain_right_edge are not yet correct. Also general testing has not poven successful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.